Skip to content

Make internal reactperflogger headers private (#58840) #58840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
j-piasecki wants to merge 2 commits into from
+8 −215
Closed

Make internal reactperflogger headers private (#58840) #58840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
302113f
Make `RuntimeExecutorSyncUIThreadUtils.h` private (#58839)
j-piasecki Oct 9, 2026
1db5baf
Make internal `reactperflogger` headers private (#58840)
j-piasecki Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/reactperflogger/fusebox/FuseboxTracer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include "folly/json/dynamic.h"

Expand Down
2 changes: 1 addition & 1 deletion ...s/react-native/ReactCommon/reactperflogger/reactperflogger/BridgeNativeModulePerfLogger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include <memory>
#include "NativeModulePerfLogger.h"
Expand Down
2 changes: 1 addition & 1 deletion ...ages/react-native/ReactCommon/reactperflogger/reactperflogger/FuseboxPerfettoDataSource.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#ifdef WITH_PERFETTO

Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/reactperflogger/reactperflogger/HermesPerfettoDataSource.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#ifdef WITH_PERFETTO

Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/reactperflogger/reactperflogger/ReactPerfetto.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#ifdef WITH_PERFETTO

Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/reactperflogger/reactperflogger/ReactPerfettoLogger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include <React/Timing.h>
#include <reactperflogger/ReactPerfettoCategories.h>
Expand Down
1 change: 0 additions & 1 deletion packages/react-native/ReactCommon/runtimeexecutor/React/RuntimeExecutor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
#define RN_UMBRELLA_CONTEXT 1

#include <ReactCommon/RuntimeExecutor.h>
#include <ReactCommon/RuntimeExecutorSyncUIThreadUtils.h>

#undef RN_UMBRELLA_CONTEXT
#pragma pop_macro("RN_UMBRELLA_CONTEXT")
2 changes: 1 addition & 1 deletion ...e/ReactCommon/runtimeexecutor/platform/cxx/ReactCommon/RuntimeExecutorSyncUIThreadUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/UmbrellaGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include <ReactCommon/RuntimeExecutor.h>

Expand Down
2 changes: 1 addition & 1 deletion ...e/ReactCommon/runtimeexecutor/platform/ios/ReactCommon/RuntimeExecutorSyncUIThreadUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/UmbrellaGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include <ReactCommon/RuntimeExecutor.h>

Expand Down
66 changes: 0 additions & 66 deletions scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1987,16 +1987,6 @@ class facebook::react::FocusOrderingHelper {
public static void traverseAndUpdateNextFocusableElement(const std::shared_ptr<const facebook::react::ShadowNode>& parentShadowNode, const std::shared_ptr<const facebook::react::ShadowNode>& focusedShadowNode, const std::shared_ptr<const facebook::react::ShadowNode>& currNode, facebook::react::FocusDirection focusDirection, const facebook::react::UIManager& uimanager, facebook::react::Rect sourceRect, std::optional<facebook::react::Rect>& nextRect, std::shared_ptr<const facebook::react::ShadowNode>& nextNode);
}

class facebook::react::FuseboxTracer {
public FuseboxTracer(const facebook::react::FuseboxTracer&) = delete;
public bool isTracing();
public bool startTracing();
public bool stopTracing(const std::function<void(const folly::dynamic& eventsChunk)>& resultCallback);
public bool stopTracingAndWriteToFile(const std::string& path);
public static facebook::react::FuseboxTracer& getFuseboxTracer();
public void addEvent(const std::string_view& name, uint64_t start, uint64_t end, const std::optional<std::string_view>& track);
}

class facebook::react::HermesInstance {
public static std::unique_ptr<JSRuntime> createJSRuntime(std::shared_ptr<hermes::vm::CrashManager> crashManager, std::shared_ptr<facebook::react::MessageQueueThread> msgQueueThread, bool allocInOldGenBeforeTTI) noexcept;
}
Expand Down Expand Up @@ -3392,12 +3382,6 @@ struct facebook::react::ReactInstance::JSRuntimeFlags {
public const std::string runtimeDiagnosticFlags;
}

class facebook::react::ReactPerfettoLogger {
public static bool isTracing();
public static void mark(const std::string_view& eventName, facebook::react::HighResTimeStamp startTime, const std::optional<std::string_view>& trackName = std::nullopt, const std::optional<std::string_view>& trackGroup = std::nullopt);
public static void measure(const std::string_view& eventName, facebook::react::HighResTimeStamp startTime, facebook::react::HighResTimeStamp endTime, const std::optional<std::string_view>& trackName = std::nullopt, const std::optional<std::string_view>& trackGroup = std::nullopt);
}

class facebook::react::ReadableNativeArray : public jni::HybridClass<facebook::react::ReadableNativeArray, facebook::react::NativeArray> {
protected friend HybridBase;
public bool equals(jni::alias_ref<ReadableNativeArray::javaobject> other);
Expand Down Expand Up @@ -5755,13 +5739,6 @@ struct facebook::react::Bridging<void> {
public static void fromJs(facebook::jsi::Runtime&, const facebook::jsi::Value&);
}

struct facebook::react::BufferEvent {
public std::string name;
public std::string track;
public uint64_t end;
public uint64_t start;
}

struct facebook::react::BundleHeader {
public BundleHeader();
public facebook::react::Magic32 magic32;
Expand Down Expand Up @@ -10049,49 +10026,6 @@ struct facebook::react::ReactMarker::ReactMarkerEvent {
}


void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallArgConversionEnd(const char* moduleName, const char* methodName);
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallArgConversionStart(const char* moduleName, const char* methodName);
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallBatchPreprocessEnd(int batchSize);
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallBatchPreprocessStart();
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallDispatch(const char* moduleName, const char* methodName);
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallEnd(const char* moduleName, const char* methodName);
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallExecutionArgConversionEnd(const char* moduleName, const char* methodName, int32_t id);
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallExecutionArgConversionStart(const char* moduleName, const char* methodName, int32_t id);
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallExecutionEnd(const char* moduleName, const char* methodName, int32_t id);
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallExecutionFail(const char* moduleName, const char* methodName, int32_t id);
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallExecutionStart(const char* moduleName, const char* methodName, int32_t id);
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallFail(const char* moduleName, const char* methodName);
void facebook::react::BridgeNativeModulePerfLogger::asyncMethodCallStart(const char* moduleName, const char* methodName);
void facebook::react::BridgeNativeModulePerfLogger::disableLogging();
void facebook::react::BridgeNativeModulePerfLogger::enableLogging(std::unique_ptr<facebook::react::NativeModulePerfLogger>&& logger);
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateCacheHit(const char* moduleName, int32_t id);
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateConstructEnd(const char* moduleName, int32_t id);
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateConstructStart(const char* moduleName, int32_t id);
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateEnd(const char* moduleName, int32_t id);
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateFail(const char* moduleName, int32_t id);
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateSetUpEnd(const char* moduleName, int32_t id);
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateSetUpStart(const char* moduleName, int32_t id);
void facebook::react::BridgeNativeModulePerfLogger::moduleCreateStart(const char* moduleName, int32_t id);
void facebook::react::BridgeNativeModulePerfLogger::moduleDataCreateEnd(const char* moduleName, int32_t id);
void facebook::react::BridgeNativeModulePerfLogger::moduleDataCreateStart(const char* moduleName, int32_t id);
void facebook::react::BridgeNativeModulePerfLogger::moduleJSRequireBeginningCacheHit(const char* moduleName);
void facebook::react::BridgeNativeModulePerfLogger::moduleJSRequireBeginningEnd(const char* moduleName);
void facebook::react::BridgeNativeModulePerfLogger::moduleJSRequireBeginningFail(const char* moduleName);
void facebook::react::BridgeNativeModulePerfLogger::moduleJSRequireBeginningStart(const char* moduleName);
void facebook::react::BridgeNativeModulePerfLogger::moduleJSRequireEndingEnd(const char* moduleName);
void facebook::react::BridgeNativeModulePerfLogger::moduleJSRequireEndingFail(const char* moduleName);
void facebook::react::BridgeNativeModulePerfLogger::moduleJSRequireEndingStart(const char* moduleName);
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallArgConversionEnd(const char* moduleName, const char* methodName);
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallArgConversionStart(const char* moduleName, const char* methodName);
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallEnd(const char* moduleName, const char* methodName);
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallExecutionEnd(const char* moduleName, const char* methodName);
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallExecutionStart(const char* moduleName, const char* methodName);
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallFail(const char* moduleName, const char* methodName);
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallReturnConversionEnd(const char* moduleName, const char* methodName);
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallReturnConversionStart(const char* moduleName, const char* methodName);
void facebook::react::BridgeNativeModulePerfLogger::syncMethodCallStart(const char* moduleName, const char* methodName);


void facebook::react::LowPriorityExecutor::execute(std::function<void()>&& workItem);


Expand Down
2 changes: 0 additions & 2 deletions scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3383,7 +3383,6 @@ uint8_t facebook::react::blueFromColor(facebook::react::SharedColor color) noexc
uint8_t facebook::react::greenFromColor(facebook::react::SharedColor color) noexcept;
uint8_t facebook::react::redFromColor(facebook::react::SharedColor color) noexcept;
void facebook::react::FBReactNativeSpec_registerComponentDescriptorsFromCodegen(std::shared_ptr<const facebook::react::ComponentDescriptorProviderRegistry> registry);
void facebook::react::executeSynchronouslyOnSameThread_CAN_DEADLOCK(const facebook::react::RuntimeExecutor& runtimeExecutor, std::function<void(facebook::jsi::Runtime&)>&& runtimeWork);
void facebook::react::fromRawValue(const facebook::react::ContextContainer& contextContainer, int32_t surfaceId, const facebook::react::RawValue& value, facebook::react::SharedColor& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext& context, const facebook::react::RawValue& value, YGValue& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext& context, const facebook::react::RawValue& value, facebook::react::AccessibilityAction& result);
Expand Down Expand Up @@ -3437,7 +3436,6 @@ void facebook::react::serializeTransformAxis(const facebook::react::TransformOpe
void facebook::react::serializeTransformOperationValue(const std::string& operationName, const facebook::react::ValueUnit& valueUnit, folly::dynamic& resultArray);
void facebook::react::setDefaultColorSpace(facebook::react::ColorSpace newColorSpace);
void facebook::react::setTouchPayloadOnObject(facebook::jsi::Object& object, facebook::jsi::Runtime& runtime, const facebook::react::BaseTouch& touch);
void facebook::react::unsafeExecuteOnMainThreadSync(std::function<void()> work);
void facebook::react::updateTransformProps(const facebook::react::Transform& transform, const facebook::react::TransformOperation& operation, folly::dynamic& resultTranslateArray);
bool facebook::react::operator==(const facebook::react::LayoutConstraints& lhs, const facebook::react::LayoutConstraints& rhs);
bool facebook::react::operator==(const facebook::react::LayoutContext& lhs, const facebook::react::LayoutContext& rhs);
Expand Down
Loading
Loading