Repository navigation
Conversation
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D123009197. |
coado
force-pushed
the
export-D123009197
branch
from
October 8, 2026 09:31
2eb6148 to
3ed1467
Compare
…#58919) Summary: Lower the following `react/renderer/components/textinput` headers from "for frameworks" to private: Platform component descriptors: - Android `androidtextinput/AndroidTextInputComponentDescriptor.h` - iOS and macOS `iostextinput/TextInputComponentDescriptor.h` All three classes are `final`, so they cannot be extended, and they are registered only by React Native's own platform glue (the Android core components registry and the iOS TextInput component view). The Android descriptor is additionally coupled to React Native's Java `FabricUIManager` (it reads theme padding over JNI in `getInitialState`). Prop conversion helpers: - `baseConversions.h` (conversions for the shared text input enums) - iOS and macOS `iostextinput/propsConversions.h` (iOS/macOS text input trait parsers) These are only included by the module's own props sources (`BaseTextInputProps.cpp` and the platform `TextInputProps.cpp` / `AndroidTextInputProps.cpp`). Changelog: [Internal] Differential Revision: D123643375
Summary: Mark the following `jsinspector-modern` headers as private instead of for-frameworks. All of them are implementation details of the inspector, and no for-frameworks header includes them: - `ConsoleTask`, `ConsoleTaskContext` and `ConsoleTaskOrchestrator` implement `console.createTask()`: the task object, the context that captures the stack trace when a task is created, and the singleton that tracks which task is currently running. They are only used by the inspector's console sources, a console test, and `PerformanceEntryReporter.cpp`, which reads the current task from the orchestrator. - `EmulationAgent` handles the CDP `Emulation` domain. It is only used by `EmulationAgent.cpp` and `HostAgent.cpp`. - `FallbackRuntimeAgentDelegate` answers CDP requests for a JavaScript runtime that does not support debugging. It is only used by `FallbackRuntimeAgentDelegate.cpp` and `FallbackRuntimeTargetDelegate.cpp`. `FallbackRuntimeTargetDelegate.h`, which creates it, stays for-frameworks. - `InspectorPackagerConnectionImpl.h` defines `InspectorPackagerConnection::Impl`, the hidden implementation of the inspector-proxy protocol. `InspectorPackagerConnection.h` only forward-declares it, and it is only used by `InspectorPackagerConnection.cpp`. `InspectorPackagerConnection.h` and `WebSocketInterfaces.h` stay for-frameworks, because each platform implements `InspectorPackagerConnectionDelegate`. - `RuntimeTargetGlobalStateObserver` installs a JavaScript global that reports a boolean state, such as whether a debugger session is active, and notifies its subscribers when the state changes. `RuntimeTargetTracingStateObserver` uses it to report whether tracing is active. Both are only used by the `RuntimeTarget` sources and their own sources. - `Utf8.h` provides `truncateToValidUTF8`, which trims a byte buffer so it does not end in the middle of a UTF-8 code point when `IO.read` slices a network resource. It is only used by `NetworkIOAgent.cpp` and its own unit test. - `ExecutionContextManager` allocates execution context IDs. It is only created by `HostTarget.cpp` and used by `InstanceTarget.cpp`. `HostTarget.h` and `InstanceTarget.h` only hold it through `std::shared_ptr`, so they now forward-declare it instead of including the header, and the two sources include it directly. React Native's own targets define `RN_BUILDING`, so the private guard does not affect them. Changelog: [Internal] Differential Revision: D123009197
coado
force-pushed
the
export-D123009197
branch
from
October 8, 2026 15:05
3ed1467 to
aac583b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Mark the following
jsinspector-modernheaders as private instead of for-frameworks. All of them are implementation details of the inspector, and no for-frameworks header includes them:ConsoleTask,ConsoleTaskContextandConsoleTaskOrchestratorimplementconsole.createTask(): the task object, the context that captures the stack trace when a task is created, and the singleton that tracks which task is currently running. They are only used by the inspector's console sources, a console test, andPerformanceEntryReporter.cpp, which reads the current task from the orchestrator.EmulationAgenthandles the CDPEmulationdomain. It is only used byEmulationAgent.cppandHostAgent.cpp.FallbackRuntimeAgentDelegateanswers CDP requests for a JavaScript runtime that does not support debugging. It is only used byFallbackRuntimeAgentDelegate.cppandFallbackRuntimeTargetDelegate.cpp.FallbackRuntimeTargetDelegate.h, which creates it, stays for-frameworks.InspectorPackagerConnectionImpl.hdefinesInspectorPackagerConnection::Impl, the hidden implementation of the inspector-proxy protocol.InspectorPackagerConnection.honly forward-declares it, and it is only used byInspectorPackagerConnection.cpp.InspectorPackagerConnection.handWebSocketInterfaces.hstay for-frameworks, because each platform implementsInspectorPackagerConnectionDelegate.RuntimeTargetGlobalStateObserverinstalls a JavaScript global that reports a boolean state, such as whether a debugger session is active, and notifies its subscribers when the state changes.RuntimeTargetTracingStateObserveruses it to report whether tracing is active. Both are only used by theRuntimeTargetsources and their own sources.Utf8.hprovidestruncateToValidUTF8, which trims a byte buffer so it does not end in the middle of a UTF-8 code point whenIO.readslices a network resource. It is only used byNetworkIOAgent.cppand its own unit test.ExecutionContextManagerallocates execution context IDs. It is only created byHostTarget.cppand used byInstanceTarget.cpp.HostTarget.handInstanceTarget.honly hold it throughstd::shared_ptr, so they now forward-declare it instead of including the header, and the two sources include it directly.React Native's own targets define
RN_BUILDING, so the private guard does not affect them.Changelog: [Internal]
Differential Revision: D123009197