Skip to content

Make select jsinspector implementation headers private (#58943) #58943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
coado wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make select jsinspector implementation headers private (#58943) #58943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d067a5
Make TextInput descriptors and prop conversion helpers private (#58919)
coado Oct 8, 2026
aac583b
Make select jsinspector implementation headers private (#58943)
coado Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/jsinspector-modern/ConsoleTask.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include <memory>

Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/jsinspector-modern/ConsoleTaskContext.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include "StackTrace.h"

Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/jsinspector-modern/ConsoleTaskOrchestrator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include <memory>
#include <mutex>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/jsinspector-modern/EmulationAgent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include "HostTarget.h"
#include "InspectorInterfaces.h"
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/jsinspector-modern/ExecutionContextManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include <cinttypes>

Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/jsinspector-modern/FallbackRuntimeAgentDelegate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include "SessionState.h"

Expand Down
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/HostTarget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
*/

#include "HostTarget.h"
#include "ExecutionContextManager.h"
#include "HostAgent.h"
#include "HostTargetTraceRecording.h"
#include "HostTargetTracing.h"
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/jsinspector-modern/HostTarget.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

#include <react/cxxstableapi/FrameworksGuard.h>

#include "ExecutionContextManager.h"
#include "HostCommand.h"
#include "InspectorInterfaces.h"
#include "InstanceTarget.h"
Expand Down Expand Up @@ -44,6 +43,7 @@

namespace facebook::react::jsinspector_modern {

class ExecutionContextManager;
class HostTargetSession;
class HostAgent;
class HostTracingAgent;
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/jsinspector-modern/InspectorPackagerConnectionImpl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include "InspectorInterfaces.h"
#include "InspectorPackagerConnection.h"
Expand Down
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/jsinspector-modern/InstanceTarget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
* LICENSE file in the root directory of this source tree.
*/

#include "ExecutionContextManager.h"
#include "InstanceAgent.h"
#include "SessionState.h"

Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/jsinspector-modern/InstanceTarget.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

#include <react/cxxstableapi/FrameworksGuard.h>

#include "ExecutionContextManager.h"
#include "RuntimeTarget.h"
#include "ScopedExecutor.h"
#include "SessionState.h"
Expand All @@ -23,6 +22,7 @@

namespace facebook::react::jsinspector_modern {

class ExecutionContextManager;
class InstanceAgent;
class InstanceTracingAgent;
class HostTargetTraceRecording;
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/jsinspector-modern/RuntimeTargetGlobalStateObserver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include <jsi/jsi.h>

Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/jsinspector-modern/RuntimeTargetTracingStateObserver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include <jsi/jsi.h>

Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/jsinspector-modern/Utf8.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include <stdexcept>
#include <vector>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/react/renderer/components/textinput/baseConversions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include <React/RendererCore.h>
#include <react/renderer/components/textinput/basePrimitives.h>
Expand Down
2 changes: 1 addition & 1 deletion .../android/react/renderer/components/androidtextinput/AndroidTextInputComponentDescriptor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include "AndroidTextInputShadowNode.h"
#include "AndroidTextInputState.h"
Expand Down
2 changes: 1 addition & 1 deletion ...tinput/platform/ios/react/renderer/components/iostextinput/TextInputComponentDescriptor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include <React/RendererCore.h>
#include <react/renderer/components/iostextinput/TextInputShadowNode.h>
Expand Down
2 changes: 1 addition & 1 deletion ...mponents/textinput/platform/ios/react/renderer/components/iostextinput/propsConversions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/FrameworksGuard.h>
#include <react/cxxstableapi/PrivateGuard.h>

#include <React/Debug.h>
#include <React/RendererCore.h>
Expand Down
94 changes: 0 additions & 94 deletions scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,7 +764,6 @@ folly::dynamic facebook::react::toDynamic(const facebook::react::FilterFunction&
folly::dynamic facebook::react::toDynamic(const facebook::react::ImageSource& imageSource);
folly::dynamic facebook::react::toDynamic(const facebook::react::Point& point);
folly::dynamic facebook::react::toDynamic(const facebook::react::SharedColor& sharedColor);
folly::dynamic facebook::react::toDynamic(const facebook::react::SubmitBehavior& value);
folly::dynamic facebook::react::toDynamic(const std::vector<bool>& arrayValue);
folly::dynamic facebook::react::toDynamic(const std::vector<double>& arrayValue);
folly::dynamic facebook::react::toDynamic(const std::vector<facebook::react::Float>& arrayValue);
Expand Down Expand Up @@ -937,7 +936,6 @@ void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, c
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::LineBreakMode& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::Point& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::Size& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::SubmitBehavior& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::TextAlignmentVertical& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::TextWidthMode& result);
void facebook::react::fromRawValue(const facebook::react::PropsParserContext&, const facebook::react::RawValue& value, facebook::react::ValueUnit& result);
Expand Down Expand Up @@ -1159,12 +1157,6 @@ class facebook::react::AndroidSwitchProps : public facebook::react::HostPlatform
public virtual folly::dynamic getDiffProps(const facebook::react::Props* prevProps) const override;
}

class facebook::react::AndroidTextInputComponentDescriptor : public facebook::react::ConcreteComponentDescriptor<facebook::react::AndroidTextInputShadowNode> {
protected virtual void adopt(facebook::react::ShadowNode& shadowNode) const override;
public AndroidTextInputComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters);
public virtual facebook::react::State::Shared createInitialState(const facebook::react::Props::Shared& props, const facebook::react::ShadowNodeFamily::Shared& family) const override;
}

class facebook::react::AndroidTextInputEventEmitter : public facebook::react::BaseViewEventEmitter {
}

Expand Down Expand Up @@ -8932,12 +8924,7 @@ template <typename Self>
facebook::react::jsinspector_modern::ScopedExecutor<Self> facebook::react::jsinspector_modern::makeScopedExecutor(std::shared_ptr<Self> self, facebook::react::jsinspector_modern::VoidExecutor executor);
template <typename Self>
facebook::react::jsinspector_modern::VoidExecutor facebook::react::jsinspector_modern::makeVoidExecutor(facebook::react::jsinspector_modern::ScopedExecutor<Self> executor);
void facebook::react::jsinspector_modern::emitGlobalStateObserverChange(facebook::jsi::Runtime& runtime, const char* globalName, const char* callbackName, bool value);
void facebook::react::jsinspector_modern::emitNotificationsForTracingProfile(facebook::react::jsinspector_modern::tracing::HostTracingProfile&& hostTracingProfile, const facebook::react::jsinspector_modern::FrontendChannel& channel, bool isBackgroundTrace);
void facebook::react::jsinspector_modern::emitTracingStateObserverChange(facebook::jsi::Runtime& runtime, bool isTracing);
void facebook::react::jsinspector_modern::installGlobalStateObserver(facebook::jsi::Runtime& runtime, const char* globalName, const char* statusProperty, const char* callbackName);
void facebook::react::jsinspector_modern::installTracingStateObserver(facebook::jsi::Runtime& runtime);
void facebook::react::jsinspector_modern::truncateToValidUTF8(std::vector<char>& buffer);

class facebook::react::jsinspector_modern::CallbackLocalConnection : public facebook::react::jsinspector_modern::ILocalConnection {
public CallbackLocalConnection(std::function<void(std::string)> handler);
Expand All @@ -8951,62 +8938,6 @@ class facebook::react::jsinspector_modern::CallbackRemoteConnection : public fac
public virtual void onMessage(std::string message) override;
}

class facebook::react::jsinspector_modern::ConsoleTask {
public ConsoleTask(const facebook::react::jsinspector_modern::ConsoleTask&) = default;
public ConsoleTask(facebook::react::jsinspector_modern::ConsoleTask&&) = default;
public ConsoleTask(std::shared_ptr<facebook::react::jsinspector_modern::ConsoleTaskContext> taskContext);
public facebook::react::jsinspector_modern::ConsoleTask& operator=(const facebook::react::jsinspector_modern::ConsoleTask&) = delete;
public facebook::react::jsinspector_modern::ConsoleTask& operator=(facebook::react::jsinspector_modern::ConsoleTask&&) = delete;
public ~ConsoleTask();
}

class facebook::react::jsinspector_modern::ConsoleTaskContext : public std::enable_shared_from_this<facebook::react::jsinspector_modern::ConsoleTaskContext> {
public ConsoleTaskContext(const facebook::react::jsinspector_modern::ConsoleTaskContext&) = delete;
public ConsoleTaskContext(facebook::jsi::Runtime& runtime, facebook::react::jsinspector_modern::RuntimeTargetDelegate& runtimeTargetDelegate, std::string name);
public ConsoleTaskContext(facebook::react::jsinspector_modern::ConsoleTaskContext&&) = delete;
public facebook::react::jsinspector_modern::ConsoleTaskContext& operator=(const facebook::react::jsinspector_modern::ConsoleTaskContext&) = delete;
public facebook::react::jsinspector_modern::ConsoleTaskContext& operator=(facebook::react::jsinspector_modern::ConsoleTaskContext&&) = delete;
public facebook::react::jsinspector_modern::ConsoleTaskId id() const;
public std::optional<folly::dynamic> getSerializedStackTrace() const;
public void schedule();
public ~ConsoleTaskContext();
}

class facebook::react::jsinspector_modern::ConsoleTaskId {
public ConsoleTaskId() = default;
public ConsoleTaskId(const facebook::react::jsinspector_modern::ConsoleTaskId&) = default;
public ConsoleTaskId(facebook::react::jsinspector_modern::ConsoleTaskId&&) = default;
public bool operator==(const facebook::react::jsinspector_modern::ConsoleTaskId&) const = default;
public facebook::react::jsinspector_modern::ConsoleTaskId& operator=(const facebook::react::jsinspector_modern::ConsoleTaskId&) = default;
public facebook::react::jsinspector_modern::ConsoleTaskId& operator=(facebook::react::jsinspector_modern::ConsoleTaskId&&) = default;
public operator bool() const;
public operator void *() const;
public ~ConsoleTaskId() = default;
}

class facebook::react::jsinspector_modern::ConsoleTaskOrchestrator {
public ConsoleTaskOrchestrator(const facebook::react::jsinspector_modern::ConsoleTaskOrchestrator&) = delete;
public ConsoleTaskOrchestrator(facebook::react::jsinspector_modern::ConsoleTaskOrchestrator&&) = delete;
public facebook::react::jsinspector_modern::ConsoleTaskOrchestrator& operator=(const facebook::react::jsinspector_modern::ConsoleTaskOrchestrator&) = delete;
public facebook::react::jsinspector_modern::ConsoleTaskOrchestrator& operator=(facebook::react::jsinspector_modern::ConsoleTaskOrchestrator&&) = delete;
public static facebook::react::jsinspector_modern::ConsoleTaskOrchestrator& getInstance();
public std::shared_ptr<facebook::react::jsinspector_modern::ConsoleTaskContext> top() const;
public void cancelTask(facebook::react::jsinspector_modern::ConsoleTaskId taskId);
public void finishTask(facebook::react::jsinspector_modern::ConsoleTaskId taskId);
public void scheduleTask(facebook::react::jsinspector_modern::ConsoleTaskId taskId, std::weak_ptr<facebook::react::jsinspector_modern::ConsoleTaskContext> taskContext);
public void startTask(facebook::react::jsinspector_modern::ConsoleTaskId taskId);
public ~ConsoleTaskOrchestrator() = default;
}

class facebook::react::jsinspector_modern::EmulationAgent {
public EmulationAgent(facebook::react::jsinspector_modern::FrontendChannel frontendChannel, facebook::react::jsinspector_modern::HostTargetController& hostTargetController);
public bool handleRequest(const facebook::react::jsinspector_modern::cdp::PreparsedRequest& req);
}

class facebook::react::jsinspector_modern::ExecutionContextManager {
public int32_t allocateExecutionContextId();
}

class facebook::react::jsinspector_modern::ExecutionContextSelector {
public ExecutionContextSelector() = delete;
public ExecutionContextSelector(const facebook::react::jsinspector_modern::ExecutionContextSelector& other) = default;
Expand All @@ -9021,11 +8952,6 @@ class facebook::react::jsinspector_modern::ExecutionContextSelector {
public ~ExecutionContextSelector() = default;
}

class facebook::react::jsinspector_modern::FallbackRuntimeAgentDelegate : public facebook::react::jsinspector_modern::RuntimeAgentDelegate {
public FallbackRuntimeAgentDelegate(facebook::react::jsinspector_modern::FrontendChannel frontendChannel, const facebook::react::jsinspector_modern::SessionState& sessionState, std::string engineDescription);
public virtual bool handleRequest(const facebook::react::jsinspector_modern::cdp::PreparsedRequest& req) override;
}

class facebook::react::jsinspector_modern::FallbackRuntimeTargetDelegate : public facebook::react::jsinspector_modern::RuntimeTargetDelegate {
public FallbackRuntimeTargetDelegate(std::string engineDescription);
public virtual bool supportsConsole() const override;
Expand Down Expand Up @@ -9210,22 +9136,6 @@ class facebook::react::jsinspector_modern::InspectorPackagerConnection {
public void sendEventToAllConnections(std::string event);
}

class facebook::react::jsinspector_modern::InspectorPackagerConnection::Impl : public facebook::react::jsinspector_modern::IWebSocketDelegate, public facebook::react::jsinspector_modern::IPageStatusListener, public std::enable_shared_from_this<facebook::react::jsinspector_modern::InspectorPackagerConnection::Impl> {
public bool isConnected() const;
public static std::shared_ptr<facebook::react::jsinspector_modern::InspectorPackagerConnection::Impl> create(std::string url, std::string deviceName, std::string appName, std::unique_ptr<facebook::react::jsinspector_modern::InspectorPackagerConnectionDelegate> delegate);
public using SessionId = uint32_t;
public void closeQuietly();
public void connect();
public void scheduleSendToPackager(folly::dynamic message, facebook::react::jsinspector_modern::InspectorPackagerConnection::Impl::SessionId sourceSessionId, const std::string& sourcePageId, const std::string& sourceProxySessionId);
public void sendEventToAllConnections(const std::string& event);
}

class facebook::react::jsinspector_modern::InspectorPackagerConnection::Impl::RemoteConnection : public facebook::react::jsinspector_modern::IRemoteConnection {
public RemoteConnection(std::weak_ptr<facebook::react::jsinspector_modern::InspectorPackagerConnection::Impl> owningPackagerConnection, std::string pageId, facebook::react::jsinspector_modern::InspectorPackagerConnection::Impl::SessionId sessionId, std::string proxySessionId);
public virtual void onDisconnect() override;
public virtual void onMessage(std::string message) override;
}

class facebook::react::jsinspector_modern::InspectorPackagerConnectionDelegate {
public virtual std::unique_ptr<facebook::react::jsinspector_modern::IWebSocket> connectWebSocket(const std::string& url, std::weak_ptr<facebook::react::jsinspector_modern::IWebSocketDelegate> delegate) = 0;
public virtual void scheduleCallback(std::function<void(void)> callback, std::chrono::milliseconds delayMs) = 0;
Expand Down Expand Up @@ -12086,10 +11996,6 @@ struct std::hash<facebook::react::AttributedString::Fragment> {
public size_t operator()(const facebook::react::AttributedString::Fragment& fragment) const;
}

struct std::hash<facebook::react::jsinspector_modern::ConsoleTaskId> {
public size_t operator()(const facebook::react::jsinspector_modern::ConsoleTaskId& id) const;
}

struct std::hash<facebook::react::jsinspector_modern::ExecutionContextSelector> {
public size_t operator()(const facebook::react::jsinspector_modern::ExecutionContextSelector& selector) const;
}
Expand Down
Loading
Loading