Repository navigation
Conversation
Summary: `RCTKeyCommands` ignored all registered key commands whenever any window had an active first responder (e.g. a focused `TextInput`), so Cmd+D intermittently failed to open the Dev Menu in the iOS Simulator / Mac Catalyst. Only unmodified key commands are now suppressed while a responder is active, so plain typing is still not intercepted while modifier shortcuts (Cmd+D, Cmd+R) fire reliably. Changelog: [iOS][Fixed] - Fix Cmd+D and other modifier key commands failing to open the Dev Menu when a view is the first responder Differential Revision: D114042042
meta-cla
Bot
added
the
CLA Signed
|
@vzaidman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D114042042. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
RCTKeyCommandsignored all registered key commands whenever any window had an active first responder (e.g. a focusedTextInput), so Cmd+D intermittently failed to open the Dev Menu in the iOS Simulator / Mac Catalyst.Only unmodified key commands are now suppressed while a responder is active, so plain typing is still not intercepted while modifier shortcuts (Cmd+D, Cmd+R) fire reliably.
Changelog:
[iOS][Fixed] - Fix Cmd+D and other modifier key commands failing to open the Dev Menu when a view is the first responder
Differential Revision: D114042042