Skip to content

Cmd+D often fails to open the React Native Dev Menu bottom sheet (#58946) #58946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vzaidman wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

Cmd+D often fails to open the React Native Dev Menu bottom sheet (#58946) #58946

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/react-native/React/Base/RCTKeyCommands.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,13 @@ - (void)handleKeyUIEventSwizzle:(UIEvent *)event
}
}

// Ignore key commands (except escape) when there's an active responder
if (!firstResponder) {
// When there's an active responder, ignore key commands that don't use a
// shortcut modifier (Command/Control/Option) so that typing into a focused
// view (e.g. a text field) isn't intercepted. Shift and Caps Lock don't
// count here since they're part of normal text input. Commands with a
// shortcut modifier (e.g. Cmd+D to open the Dev Menu) should still fire.
UIKeyModifierFlags shortcutModifiers = UIKeyModifierCommand | UIKeyModifierControl | UIKeyModifierAlternate;
if (!firstResponder || (modifierFlags & shortcutModifiers) != 0) {
[self RCT_handleKeyCommand:modifiedInput flags:modifierFlags];
}
}
Expand Down
Loading