Skip to content

Make the HelloWorld dynamic-frameworks CI lane actually use dynamic frameworks - #58962

Open
xThreeh wants to merge 1 commit into
react:mainfrom
xThreeh:ci/helloworld-dynamic-frameworks
Open

xThreeh wants to merge 1 commit into
react:mainfrom
xThreeh:ci/helloworld-dynamic-frameworks

Conversation

@xThreeh

@xThreeh xThreeh commented Oct 9, 2026

Copy link
Copy Markdown

Summary:

#54482 changed the test_ios_helloworld matrix from use_frameworks: [StaticLibraries, DynamicFrameworks] to [false, true] and updated test-ios-rntester to match, but test-ios-helloworld still checks the input against "DynamicFrameworks":

if [[ ${{ inputs.use-frameworks }} == "DynamicFrameworks" ]]; then
  args+=(--frameworks dynamic)
fi

So the true lane builds with static libraries, the same as the false lane, and HelloWorld with dynamic frameworks is no longer tested. The Debug exclude (use_frameworks: StaticLibraries) also matches nothing, so (Debug, false) runs even though the Ruby 3.2.0 job already covers it. The latest Test All run on main shows all four test_ios_helloworld combinations.

This makes the action compare the input to "true", as test-ios-rntester does, and changes the exclude to use_frameworks: false. The Ruby 3.2.0 job passes no use-frameworks, so it keeps the default and still builds static libraries.

Changelog:

[INTERNAL] [FIXED] - Make the HelloWorld dynamic-frameworks CI lane use dynamic frameworks

Test Plan:

  • actionlint on test-all.yml: the "value StaticLibraries in exclude does not match" error is gone.
  • On this PR, Test All should run three test_ios_helloworld jobs, and the (…, true) ones should pass --frameworks dynamic to yarn bootstrap ios.

react#54482 switched the test_ios_helloworld matrix to use_frameworks: [false, true] but left the test-ios-helloworld action comparing the input to "DynamicFrameworks", so the true lane builds with static libraries and the Debug exclude (StaticLibraries) matches nothing. Compare against "true" like test-ios-rntester does and exclude use_frameworks: false.
@meta-cla

meta-cla Bot commented Oct 9, 2026

Copy link
Copy Markdown

Hi @xThreeh!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@meta-cla

meta-cla Bot commented Oct 9, 2026

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 9, 2026
@facebook-github-tools facebook-github-tools Bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Oct 9, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant