Repository navigation
Conversation
react#54482 switched the test_ios_helloworld matrix to use_frameworks: [false, true] but left the test-ios-helloworld action comparing the input to "DynamicFrameworks", so the true lane builds with static libraries and the Debug exclude (StaticLibraries) matches nothing. Compare against "true" like test-ios-rntester does and exclude use_frameworks: false.
|
Hi @xThreeh! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary:
#54482 changed the
test_ios_helloworldmatrix fromuse_frameworks: [StaticLibraries, DynamicFrameworks]to[false, true]and updatedtest-ios-rntesterto match, buttest-ios-helloworldstill checks the input against"DynamicFrameworks":So the
truelane builds with static libraries, the same as thefalselane, and HelloWorld with dynamic frameworks is no longer tested. The Debug exclude (use_frameworks: StaticLibraries) also matches nothing, so(Debug, false)runs even though the Ruby 3.2.0 job already covers it. The latest Test All run on main shows all fourtest_ios_helloworldcombinations.This makes the action compare the input to
"true", astest-ios-rntesterdoes, and changes the exclude touse_frameworks: false. The Ruby 3.2.0 job passes nouse-frameworks, so it keeps the default and still builds static libraries.Changelog:
[INTERNAL] [FIXED] - Make the HelloWorld dynamic-frameworks CI lane use dynamic frameworks
Test Plan:
actionlintontest-all.yml: the "value StaticLibraries in exclude does not match" error is gone.test_ios_helloworldjobs, and the(…, true)ones should pass--frameworks dynamictoyarn bootstrap ios.