Skip to content

Make the HelloWorld dynamic-frameworks CI lane actually use dynamic frameworks #58962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xThreeh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make the HelloWorld dynamic-frameworks CI lane actually use dynamic frameworks #58962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/actions/test-ios-helloworld/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ name: test-ios-helloworld
description: Test iOS Hello World
inputs:
use-frameworks:
description: The dependency building and linking strategy to use. Must be one of "StaticLibraries", "DynamicFrameworks"
default: StaticLibraries
description: Whether to build with dynamic frameworks.
default: false
ruby-version:
description: The version of ruby that must be used
default: 2.6.10
Expand Down Expand Up @@ -51,7 +51,7 @@ runs:
cd private/helloworld
args=()

if [[ ${{ inputs.use-frameworks }} == "DynamicFrameworks" ]]; then
if [[ "${{ inputs.use-frameworks }}" == "true" ]]; then
args+=(--frameworks dynamic)
fi

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-all.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ jobs:
exclude:
# This config is tested with Ruby 3.2.0. Let's not double test it.
- flavor: Debug
use_frameworks: StaticLibraries
use_frameworks: false
env:
PROJECT_NAME: iOSTemplateProject
YARN_ENABLE_IMMUTABLE_INSTALLS: false
Expand Down
Loading