Repository navigation
Move RecoverableError to its own target and the frameworks tier (#59027) - #59027
Open
j-piasecki wants to merge 1 commit into
Open
j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D124957581. |
…t#59027) Summary: `cxxreact/RecoverableError.h` was exported only by `cxxreact:bridge` and guarded as private, so libraries could not use it under `RN_STRICT_API`, and the bridgeless Android runtime had to depend on the bridge to get it. - Add a header-only `cxxreact:recoverableerror` target. The include path stays `<cxxreact/RecoverableError.h>`; `cxxreact:bridge` re-exports it for existing users. - Move the header from the private tier to "for frameworks" (`FrameworksGuard.h`). - `ReactAndroid`'s `runtime/jni` depends on `cxxreact:recoverableerror` instead of `cxxreact:bridge`. - Remove the unused include from `Instance.cpp`. Changelog: [General][Changed] - Move `RecoverableError` from private headers to "for frameworks" headers Differential Revision: D124957581
meta-codesync
Bot
changed the title
j-piasecki
force-pushed
the
export-D124957581
branch
from
October 14, 2026 08:19
b47b96b to
8d554fc
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
cxxreact/RecoverableError.hwas exported only bycxxreact:bridgeand guarded as private, so libraries could not use it underRN_STRICT_API, and the bridgeless Android runtime had to depend on the bridge to get it.cxxreact:recoverableerrortarget. The include path stays<cxxreact/RecoverableError.h>;cxxreact:bridgere-exports it for existing users.FrameworksGuard.h).ReactAndroid'sruntime/jnidepends oncxxreact:recoverableerrorinstead ofcxxreact:bridge.Instance.cpp.Changelog:
[General][Changed] - Move
RecoverableErrorfrom private headers to "for frameworks" headersDifferential Revision: D124957581