Skip to content

Move RecoverableError to its own target and the frameworks tier (#59027) #59027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
j-piasecki wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move RecoverableError to its own target and the frameworks tier (#59027) #59027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/react-native/ReactCommon/cxxreact/Instance.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
#include "MethodCall.h"
#include "NativeToJsBridge.h"
#include "RAMBundleRegistry.h"
#include "RecoverableError.h"
#include "TraceSection.h"

#include <folly/json.h>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native/ReactCommon/cxxreact/RecoverableError.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>
#include <react/cxxstableapi/FrameworksGuard.h>

#include <exception>
#include <functional>
Expand Down
7 changes: 7 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6440,6 +6440,13 @@ struct facebook::react::ReadableType : public facebook::jni::JavaClass<facebook:
public static jni::alias_ref<facebook::react::ReadableType> getType(folly::dynamic::Type type);
}

struct facebook::react::RecoverableError : public std::exception {
public RecoverableError(const std::string& what_);
public virtual const char* what() const noexcept override;
template <typename E>
public static void runRethrowingAsRecoverable(std::function<void()> act);
}

struct facebook::react::Rect {
public bool containsPoint(facebook::react::Point point) noexcept;
public bool operator==(const facebook::react::Rect& rhs) const noexcept = default;
Expand Down
7 changes: 7 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactAppleFrameworksCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8475,6 +8475,13 @@ struct facebook::react::ReactNativeVersionType {
public std::string_view Prerelease;
}

struct facebook::react::RecoverableError : public std::exception {
public RecoverableError(const std::string& what_);
public virtual const char* what() const noexcept override;
template <typename E>
public static void runRethrowingAsRecoverable(std::function<void()> act);
}

struct facebook::react::Rect {
public bool containsPoint(facebook::react::Point point) noexcept;
public bool operator==(const facebook::react::Rect& rhs) const noexcept = default;
Expand Down
7 changes: 7 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactCommonFrameworksCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4621,6 +4621,13 @@ struct facebook::react::ReactNativeVersionType {
public std::string_view Prerelease;
}

struct facebook::react::RecoverableError : public std::exception {
public RecoverableError(const std::string& what_);
public virtual const char* what() const noexcept override;
template <typename E>
public static void runRethrowingAsRecoverable(std::function<void()> act);
}

struct facebook::react::Rect {
public Float getMaxX() const noexcept;
public Float getMaxY() const noexcept;
Expand Down
Loading