Repository navigation
Fix the deploy test, add a Spanish home, and refresh the no-JS snapshot - #168
Merged
Merged
Conversation
…snapshot. A late map focus callback could take the search field and fail the Pages test. /es/ is the indexable Spanish home. On Vercel the no-JS snapshot frame uses the cached CBP fetch instead of the last full site build. Co-authored-by: Sebastian Becerra <sbc1-code@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mobile search-focus failure in production run 41499379953 blocked publication. This change protects an active editing field from deferred map selection/restoration callbacks and cancels outdated callbacks.
/es/owns the Spanish dashboard, shell, footer and shared preference, including a visitor with saved English. Switching to English preserves query/hash state. Canonicals, reciprocal language alternates, sitemap and no-JS Spanish entry are retained.The no-JS home frame uses
/snapshot/: Vercel renders sourced CBP data as labeled snapshot HTML; Pages uses its published snapshot file. Upstream and known-host bundled recovery share an 8.5-second request budget under the existing ten-second function limit. Fallback preserves original retrieval/report clocks; unavailable responses remain explicit and uncached. CDN reuse permits five minutes plus up to ten minutes of stale revalidation, so it is not a strict five-minute freshness promise. Shared crossing URLs remain unchanged.Integration state
Current head:
902311654fc207b9cf07f5a39c6086e4864b8eae. Intended order: #168 → #170 → #169. #168 contains task-start main baseline99fa2255; #170 includes prepared #168; #169 includes prepared #170, so #169 is the full combined candidate. PR bases remain main. Later PR diffs include earlier fixes until integration proceeds in order.Conflicts are resolved in the pushed branches, preserving both endpoint regression groups and N/A expectations, both sitemap imports, all reviewed documentation and current-main data. Subsequent main updates observed during testing changed feed data only and were not overwritten. Source guards, freshness/missing/zero states, native branding, keyboard/focus, reduced motion and share cautions remain intact.
Original feature work is by Cursor; Codex authored the correction and preparation commits. Review/preparation only: production approval is still pending. No shared-main merge, formal approval review, auto-merge, publisher rerun or production deployment was performed.
Current-head validation
npm testpassed on this exact commit: 239 unit checks and 418 desktop/mobile browser navigations. Entry JS 61.48/62 KiB; CSS 19.87/20 KiB. Budgets are unchanged.npm test: 239 unit checks and 418 browser navigations. CI entry JS 61.52/62 KiB, CSS 19.87/20 KiB; audit 0 high/critical, 1 moderate. Budgets and gates are unchanged.tsc --noEmit -p jsconfig.jsonreports 216 diagnostics. Untouched main also has 216 diagnostics; the candidate retains the same legacy categories, with an inferred metadata-message variation. No compiler exclusions or checks were weakened.