Repository navigation
Keep the selected lane across Best time links - #178
Merged
Merged
Conversation
Opening "Plan your crossing" or the card menu's Best time dropped the ?lane= key, and "See current wait time" then returned to Standard (25 to 185 minutes in the audit's SENTRI test). Pass the validated lane through withLane() on the share link, both card links and the Best time return link. Show a short EN/ES note on Best time when a non-Standard lane is selected, since that history is standard-passenger. The share test had asserted a lane-free link for every lane; it now expects the lane key. Add a withLane contract test. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JB1Z5HSRuMsFpDeoEX6spM
sbc1-code
marked this pull request as ready for review
November 8, 2026 05:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
From the Nov 7 BorderPulse audit: with SENTRI selected,
Plan your crossingthenSee current wait timereturned to the Standard lane. In the audit's sampled test the displayed wait changed from 25 to 185 minutes (test observations, not current waits).Cause: the lane lives in the URL (
?lane=). The crossing-share link, two card links and Best time's return link all dropped it. Dashboard card links to the crossing page already usedwithLane(); these did not.Changes
withLane()on:CrossingSharebest-time link, bothBorderCrossingCardbest-time links, and Best time's "See current wait time" link.scripts/test-crossing-share.mjshad asserted a lane-free best-time link for every lane, which encoded the bug. It now expects the lane key. Added awithLanecontract test.Verified
npm testsuites pass throughtest:audit;test:bundlepasses after a build (entry 61.79 KB of 62 KB budget);test:routespasses (476 navigations).Not in this PR
"View trends" menu item, Walk or Drive wording, empty Analytics view, scroll position, mixed English in Spanish UI, accessibility items. The paused collector backup repair (
codex/collector-backup-review-20261105) is untouched.Draft. Do not merge until Sebastian approves.
Generated by Claude Code