Repository navigation
Correct DR4 stellar orbit sign and add Gaia-4 and BH3 tutorials - #462
clarissardoo wants to merge 23 commits into
Conversation
sblunt
left a comment
There was a problem hiding this comment.
Hey, in general this looks good, but why are you saving the orbit sign? I don't think we want users to be able to change the sign; it should always be the same. I'd suggest removing the sign hdf5 attribute and also removing the global variable from the top of simualte_dr4.py
|
Other comments (pasting from our convo on slack):
EAS tutorial:
|
|
|
BH3 tutorial:
|
|
|
OHP tutorial:
|
Add multi-planet Gaia DR4 simulation and μ Ara notebook
| """ | ||
|
|
||
| for body_num in np.arange(self.num_secondary_bodies) + 1: | ||
| # Cache these before their slots become periods and K. |
There was a problem hiding this comment.
can you make this comment more descriptive?
| m_n = param_arr[self.standard_basis_idx[f"m{body_num}"]] | ||
| m0 = param_arr[self.standard_basis_idx["m0"]] | ||
| mtot = m_n + m0 | ||
| mtot = m0 + np.sum(np.where(all_smas <= sma, all_masses, 0.0), axis=0) |
There was a problem hiding this comment.
I don't love that this logic is repeated wrt the Jacobi logic in system, but don't have a great idea of how to abstract it out. maybe we could define jacobi_mtot, and use that in system?
|
I took a look at the semiamp basis changes, and those look good. It's good we're being more consistent about using jacobi coordinates throughout. I made a small suggestion about trying to abstract out some code. |
Correct the stellar orbit sign in DR4 likelihood, plotting, and simulation; update regression tests; add Gaia-4 and BH3 notebooks and Gaia-4 RV data.