LT-22314: Remove media case in AddFreeformComment#759
Open
aror92 wants to merge 2 commits intorelease/9.3.7from
Open
LT-22314: Remove media case in AddFreeformComment#759aror92 wants to merge 2 commits intorelease/9.3.7from
aror92 wants to merge 2 commits intorelease/9.3.7from
Conversation
Media is handled in AddMedia; a media case in AddFreeformComment is not needed. Remove this case, and delete the media label with trailing space resource that it was using. Change-Id: I354d507e49874197700f2bed6f2dd3a8533b2929
jasonleenaylor
approved these changes
Mar 13, 2026
Contributor
jasonleenaylor
left a comment
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on aror92).
Keep "No Media" message when no media filepath is specified. Add the message "Media not found: check Info tab for file name" for the case when a media filepath is specified but the file does not exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Media is handled in AddMedia; the media case in AddFreeformComment is not needed. Remove this case, and delete the media label with trailing space resource that it was using.
This change is