Skip to content

LT-22314: Remove media case in AddFreeformComment #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aror92 merged 1 commit into from
Mar 17, 2026
Merged

LT-22314: Remove media case in AddFreeformComment #759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions Src/LexText/Interlinear/ITextStrings.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions Src/LexText/Interlinear/ITextStrings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,10 +344,6 @@
<data name="ksMedia" xml:space="preserve">
<value>Media</value>
</data>
<data name="ksMedia_" xml:space="preserve">
<value>Media </value>
<comment>there is a trailing space</comment>
</data>
<data name="ksMediaNotFound" xml:space="preserve">
<value>Media not found: check Info tab for file name</value>
<comment>Used when a media filepath is specified, but the file doesn't exist. Ensure translation of "Info" matches translation used for the tab label.</comment>
Expand Down
6 changes: 0 additions & 6 deletions Src/LexText/Interlinear/InterlinVc.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1441,12 +1441,6 @@ protected virtual void AddFreeformComment(IVwEnv vwenv, int hvoSeg, int lineChoi
if (exporter != null)
exporter.FreeAnnotationType = "note";
break;
case InterlinLineChoices.kflidMedia:
label = ITextStrings.ksMedia_;
flid = SegmentTags.kflidMediaURI;
if (exporter != null)
exporter.FreeAnnotationType = "media";
break;
default:
throw new Exception("Unexpected FF annotation type");
}
Expand Down
Loading