fix: stabilize ai inspector worker execution#490
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 14 minutes and 4 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
고차원적 변경 사항 정리이 풀 리퀘스트는 AI Inspector 워커를 GitHub Actions 자동화에서 로컬 프로세스 기반 실행으로 전환합니다.
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~35 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 31b8e1efdd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| git config user.email "41898282+github-actions[bot]@users.noreply.github.com" | ||
|
|
||
| - name: Install worker dependencies | ||
| run: npm install firebase-admin |
There was a problem hiding this comment.
Change this step to avoid npm saving into the repo (npm install --no-save firebase-admin or preinstall via the workspace lockfile). In this workflow, npm install firebase-admin runs before the script does git checkout -B ..., and npm’s default save=true (confirmed via npm config get save) updates tracked package.json; that makes git checkout fail with local changes when a queued task is actually processed, so the worker cannot claim/commit tasks.
Useful? React with 👍 / 👎.
manNomi
force-pushed
the
codex/fix-turbo-web-build-env-warnings
branch
from
a69d516 to
8547143
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85471436c9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| .where("status", "==", "queued") | ||
| .orderBy("createdAt", "asc") | ||
| .limit(10) | ||
| .get(); |
There was a problem hiding this comment.
This query now applies limit(10) without any Firestore orderBy, then sorts only the fetched subset in memory, so when more than 10 tasks are queued the worker no longer sees the true oldest tasks. In production backlogs, newer requests can be processed ahead of older ones and older tasks can be delayed indefinitely under sustained load, which is a regression from the previous FIFO behavior.
Useful? React with 👍 / 👎.
1 participant
Summary\n- include web build env groups in turbo to remove missing env warnings\n- avoid Firestore composite index requirement when claiming queued inspector tasks\n- configure git author in AI Inspector Worker workflow so worker commits can be created on Actions runner\n\n## Verification\n- node --check .github/scripts/ai-inspector-worker.mjs\n- manually dispatched AI Inspector Worker workflow on this branch\n - run 23637510433 succeeded\n - worker log showed no queued inspector tasks\n