-
Notifications
You must be signed in to change notification settings - Fork 3
fix: stabilize ai inspector worker execution #490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
573dff3
chore(turbo): include build env groups for web warnings
manNomi 61d343d
fix(worker): avoid firestore composite index for queued tasks
manNomi 467b0a6
fix(worker): configure git author in action runner
manNomi 8547143
refactor(ai-inspector): run worker locally without github actions
manNomi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| import { execFileSync } from "node:child_process"; | ||
| import process from "node:process"; | ||
|
|
||
| const ONE_SECOND = 1_000; | ||
| const defaultIntervalSeconds = 15 * 60; | ||
|
|
||
| const parseIntervalSeconds = () => { | ||
| const rawValue = process.env.AI_INSPECTOR_POLL_INTERVAL_SECONDS; | ||
| if (!rawValue) { | ||
| return defaultIntervalSeconds; | ||
| } | ||
|
|
||
| const value = Number(rawValue); | ||
| if (!Number.isFinite(value) || value <= 0) { | ||
| throw new Error("AI_INSPECTOR_POLL_INTERVAL_SECONDS must be a positive number."); | ||
| } | ||
|
|
||
| return value; | ||
| }; | ||
|
|
||
| const runOnce = async () => { | ||
| execFileSync("node", [".github/scripts/ai-inspector-worker.mjs"], { | ||
| stdio: "inherit", | ||
| env: process.env, | ||
| }); | ||
| }; | ||
|
|
||
| const sleep = async (ms) => | ||
| new Promise((resolve) => { | ||
| setTimeout(resolve, ms); | ||
| }); | ||
|
|
||
| const loop = async () => { | ||
| const intervalSeconds = parseIntervalSeconds(); | ||
| while (true) { | ||
| const startedAt = Date.now(); | ||
| try { | ||
| await runOnce(); | ||
| } catch (error) { | ||
| const message = error instanceof Error ? error.message : String(error); | ||
| console.error(`[ai-inspector-worker-loop] run failed: ${message}`); | ||
| } | ||
|
|
||
| const elapsed = Date.now() - startedAt; | ||
| const waitMs = Math.max(ONE_SECOND, intervalSeconds * ONE_SECOND - elapsed); | ||
| await sleep(waitMs); | ||
| } | ||
| }; | ||
|
|
||
| loop().catch((error) => { | ||
| console.error(error); | ||
| process.exit(1); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This query now applies
limit(10)without any FirestoreorderBy, then sorts only the fetched subset in memory, so when more than 10 tasks are queued the worker no longer sees the true oldest tasks. In production backlogs, newer requests can be processed ahead of older ones and older tasks can be delayed indefinitely under sustained load, which is a regression from the previous FIFO behavior.Useful? React with 👍 / 👎.