Repository navigation
ci(rust): bump napi from 3.15.0 to 3.16.1 - #202
dependabot[bot] wants to merge 4 commits into
Conversation
Bumps [napi](https://github.com/napi-rs/napi-rs) from 3.15.0 to 3.16.1. - [Release notes](https://github.com/napi-rs/napi-rs/releases) - [Commits](napi-rs/napi-rs@napi-v3.15.0...napi-v3.16.1) --- updated-dependencies: - dependency-name: napi dependency-version: 3.16.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
strandly-the-agent
left a comment
There was a problem hiding this comment.
Verdict: Safe to merge: lockfile-only patch pair (3.16.0 adds well-known-symbol class keys, 3.16.1 fixes a tokio_rt deadlock) with no public-API removals; full workspace tests green on the head.
| Package | From → To | Tier | Scope |
|---|---|---|---|
| napi | 3.15.0 → 3.16.1 | minor | lockfile-only (Cargo.toml:52 keeps version = "3", features = ["napi9", "tokio_rt"]); node feature, shipped npm binary |
Breaking for this repo: None found. The crate diff touches src/tokio_runtime.rs, threadsafe_function.rs, bindgen_runtime/* (symbol-key class members) and adds no removals or renames; build.rs unchanged; napi-derive stays 3.6.13 / backend 6.1.6. src/js.rs:27-28 imports only bindgen_prelude::* and napi::tokio::sync::oneshot; the #[napi] async methods (src/js.rs:396-547) run on napi's built-in runtime, which is exactly what 3.16.1 fixes — fill_empty_tokio_runtime() now takes the read lock first so a worker_threads env loading the addon during block_on no longer deadlocks. That is a fix we benefit from, not a risk.
Tests: cargo test --lib --features node --locked ✓ 55/55 · cargo test --workspace --all-targets --locked ✓ (shell_integration 1470, lua 227, vfs 96, curl 60, mcp 39, command_fallback 21, config 7, custom_kernel 9, path_resolution_cost 1; 0 failed) on head 7190fe0, rustc 1.99.1 aarch64 · CI: all 31 checks green (Rust/Python/Node matrices) · skipped: napi build of the Node addon (CI's 9 Node.js legs cover it).
Supply chain: no flags — no build.rs change, no new transitive crates, 3.16.1 published 2026-10-30 (>3 days), not yanked, MSRV unchanged.
Details
- Supersedes #191 (3.16.0, closed). Interaction with the still-open #192 (napi-derive 3.7.0 / backend 7.0.0): backend 7.0.0's only new napi path is
napi::symbol_for_property!, which needs napi ≥ 3.16.0 — so this PR is the prerequisite that makes #192 safe, as noted there. - Release notes read: 3.16.0 (
#3665well-known symbol keys for class members), 3.16.1 (#3670deadlock fix). - Evidence in the artifact bucket for this PR:
cargo-test.log,napi-crate-diff.txt.
|
A newer version of napi exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Bumps napi from 3.15.0 to 3.16.1.
Release notes
Sourced from napi's releases.
Commits
417375achore: release (#3671)9ffcf8dbuild(deps): bump qs from 6.16.0 to 6.17.1 (#3669)8a89547fix(napi): avoid a deadlock when a worker loads the addon duringblock_on(...eec0c64chore(deps): update dependency oxfmt to ^0.75.0 (#3660)f89400dchore: release (#3637)192cbaachore(deps): update dependency@types/inquirerto v10 (#3668)9188219chore(deps): update dependency electron to v45 (#3634)1d93a4efix(napi): compact class identity metadata (#3667)e9de902fix(napi): keep the registered classes when a later load fails (#3666)cad7ff7feat(napi): support well-known symbol keys for class members (#3665)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)