Skip to content

ci(rust): bump napi from 3.15.0 to 3.16.0 - #191

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/cargo/napi-3.16.0
Closed

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/cargo/napi-3.16.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 2, 2026

Copy link
Copy Markdown
Contributor

Bumps napi from 3.15.0 to 3.16.0.

Release notes

Sourced from napi's releases.

napi-v3.16.0

Added

  • (napi) support well-known symbol keys for class members (#3665)
  • (napi) support symbol_for keys for class members (#3661)

Fixed

  • (napi) compact class identity metadata (#3667)
  • (napi) keep the registered classes when a later load fails (#3666)
  • (napi) free define_class closures, honour static flags, avoid TS1016 in constructors (#3662)
  • (napi) free threadsafe function call data when the call fails (#3656)
Commits
  • f89400d chore: release (#3637)
  • 192cbaa chore(deps): update dependency @​types/inquirer to v10 (#3668)
  • 9188219 chore(deps): update dependency electron to v45 (#3634)
  • 1d93a4e fix(napi): compact class identity metadata (#3667)
  • e9de902 fix(napi): keep the registered classes when a later load fails (#3666)
  • cad7ff7 feat(napi): support well-known symbol keys for class members (#3665)
  • c01ce60 fix(napi): free define_class closures, honour static flags, avoid TS1016 in c...
  • 5a49dad feat(napi): support symbol_for keys for class members (#3661)
  • 0c58903 fix(napi): free threadsafe function call data when the call fails (#3656)
  • ada66a3 chore(deps): update release-plz/action action to v0.5.147 (#3659)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [napi](https://github.com/napi-rs/napi-rs) from 3.15.0 to 3.16.0.
- [Release notes](https://github.com/napi-rs/napi-rs/releases)
- [Commits](napi-rs/napi-rs@napi-v3.15.0...napi-v3.16.0)

---
updated-dependencies:
- dependency-name: napi
  dependency-version: 3.16.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file rust Pull requests that update rust code labels Nov 2, 2026
@dependabot
dependabot Bot requested a review from a team as a code owner November 2, 2026 12:55

@strandly-the-agent strandly-the-agent left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Safe to merge: napi 3.16.0 is additive (symbol keys for class members) plus leak/identity fixes; compiles against the locked napi-derive 3.6.13 and the Node addon builds and passes its tests.

Package From → To Tier Scope
napi 3.15.0 → 3.16.0 minor (lockfile-only, node feature) runtime of the shipped Node addon

Breaking for this repo: None found. src/js.rs uses #[napi]/#[napi(object)]/#[napi(constructor)] only (src/js.rs:151-322); no symbol-keyed members, so the new with_symbol_name/with_well_known_symbol surface isn't reached. MSRV stays 1.88.
Tests: cargo check --features node --locked ✓ · cargo test --features node --locked --lib -- js::tests ✓ (2/2 — these run in no CI job) · cargo check --workspace --all-targets --locked ✓ · npm install && npm run build:debug && npm test ✓ (41/41) · with #192 applied too: all of the above ✓ plus cargo test --workspace --all-targets --locked ✓ (1470 + 227 + 60 + 53 + 39 + 21 + 7 + 1 passed, 0 failed)
Supply chain: no flags (released 2026-10-30, not yanked, no new crates, build.rs unchanged, published in lockstep with napi-derive 3.7.0)

Details

Crate diff 3.15.0→3.16.0 touches bindgen_runtime/{callback_info,class_identity,module_register}.rs, js_values/{class,object,object_property}.rs, env.rs, threadsafe_function.rs (~1250 changed lines). CHANGELOG: added symbol / Symbol.for keys for class members (#3661, #3665); fixed compact class identity metadata (#3667), keep registered classes when a later load fails (#3666), free define_class closures + honour static flags (#3662), free TSFN call data when the call fails (#3656). Generated native.js export shape (ShellBuilder, Shell, Shell.builder, Shell.prototype.run descriptors) is identical before and after. Merges independently of #192 in either order.

@dependabot @github

dependabot Bot commented on behalf of github Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #202.

@dependabot dependabot Bot closed this Nov 3, 2026
@dependabot
dependabot Bot deleted the dependabot/cargo/napi-3.16.0 branch November 3, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant