Repository navigation
ci(rust): bump napi from 3.15.0 to 3.16.0 - #191
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [napi](https://github.com/napi-rs/napi-rs) from 3.15.0 to 3.16.0. - [Release notes](https://github.com/napi-rs/napi-rs/releases) - [Commits](napi-rs/napi-rs@napi-v3.15.0...napi-v3.16.0) --- updated-dependencies: - dependency-name: napi dependency-version: 3.16.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
strandly-the-agent
left a comment
There was a problem hiding this comment.
Verdict: Safe to merge: napi 3.16.0 is additive (symbol keys for class members) plus leak/identity fixes; compiles against the locked napi-derive 3.6.13 and the Node addon builds and passes its tests.
| Package | From → To | Tier | Scope |
|---|---|---|---|
| napi | 3.15.0 → 3.16.0 | minor (lockfile-only, node feature) |
runtime of the shipped Node addon |
Breaking for this repo: None found. src/js.rs uses #[napi]/#[napi(object)]/#[napi(constructor)] only (src/js.rs:151-322); no symbol-keyed members, so the new with_symbol_name/with_well_known_symbol surface isn't reached. MSRV stays 1.88.
Tests: cargo check --features node --locked ✓ · cargo test --features node --locked --lib -- js::tests ✓ (2/2 — these run in no CI job) · cargo check --workspace --all-targets --locked ✓ · npm install && npm run build:debug && npm test ✓ (41/41) · with #192 applied too: all of the above ✓ plus cargo test --workspace --all-targets --locked ✓ (1470 + 227 + 60 + 53 + 39 + 21 + 7 + 1 passed, 0 failed)
Supply chain: no flags (released 2026-10-30, not yanked, no new crates, build.rs unchanged, published in lockstep with napi-derive 3.7.0)
Details
Crate diff 3.15.0→3.16.0 touches bindgen_runtime/{callback_info,class_identity,module_register}.rs, js_values/{class,object,object_property}.rs, env.rs, threadsafe_function.rs (~1250 changed lines). CHANGELOG: added symbol / Symbol.for keys for class members (#3661, #3665); fixed compact class identity metadata (#3667), keep registered classes when a later load fails (#3666), free define_class closures + honour static flags (#3662), free TSFN call data when the call fails (#3656). Generated native.js export shape (ShellBuilder, Shell, Shell.builder, Shell.prototype.run descriptors) is identical before and after. Merges independently of #192 in either order.
|
Superseded by #202. |
Bumps napi from 3.15.0 to 3.16.0.
Release notes
Sourced from napi's releases.
Commits
f89400dchore: release (#3637)192cbaachore(deps): update dependency@types/inquirerto v10 (#3668)9188219chore(deps): update dependency electron to v45 (#3634)1d93a4efix(napi): compact class identity metadata (#3667)e9de902fix(napi): keep the registered classes when a later load fails (#3666)cad7ff7feat(napi): support well-known symbol keys for class members (#3665)c01ce60fix(napi): free define_class closures, honour static flags, avoid TS1016 in c...5a49dadfeat(napi): support symbol_for keys for class members (#3661)0c58903fix(napi): free threadsafe function call data when the call fails (#3656)ada66a3chore(deps): update release-plz/action action to v0.5.147 (#3659)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)