Skip to content

ci(rust): bump napi-derive from 3.6.13 to 3.7.0 - #192

Open
dependabot[bot] wants to merge 4 commits into
mainfrom
dependabot/cargo/napi-derive-3.7.0
Open

dependabot[bot] wants to merge 4 commits into
mainfrom
dependabot/cargo/napi-derive-3.7.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 2, 2026

Copy link
Copy Markdown
Contributor

Bumps napi-derive from 3.6.13 to 3.7.0.

Release notes

Sourced from napi-derive's releases.

napi-derive-v3.7.0

Added

  • (napi) support well-known symbol keys for class members (#3665)
  • (napi) support symbol_for keys for class members (#3661)

Fixed

  • (napi) free define_class closures, honour static flags, avoid TS1016 in constructors (#3662)
Commits
  • f89400d chore: release (#3637)
  • 192cbaa chore(deps): update dependency @​types/inquirer to v10 (#3668)
  • 9188219 chore(deps): update dependency electron to v45 (#3634)
  • 1d93a4e fix(napi): compact class identity metadata (#3667)
  • e9de902 fix(napi): keep the registered classes when a later load fails (#3666)
  • cad7ff7 feat(napi): support well-known symbol keys for class members (#3665)
  • c01ce60 fix(napi): free define_class closures, honour static flags, avoid TS1016 in c...
  • 5a49dad feat(napi): support symbol_for keys for class members (#3661)
  • 0c58903 fix(napi): free threadsafe function call data when the call fails (#3656)
  • ada66a3 chore(deps): update release-plz/action action to v0.5.147 (#3659)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [napi-derive](https://github.com/napi-rs/napi-rs) from 3.6.13 to 3.7.0.
- [Release notes](https://github.com/napi-rs/napi-rs/releases)
- [Commits](napi-rs/napi-rs@napi-derive-v3.6.13...napi-derive-v3.7.0)

---
updated-dependencies:
- dependency-name: napi-derive
  dependency-version: 3.7.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file rust Pull requests that update rust code labels Nov 2, 2026
@dependabot
dependabot Bot requested a review from a team as a code owner November 2, 2026 12:55

@strandly-the-agent strandly-the-agent left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Safe to merge: unlike #184, this napi-derive bump does not need a newer napi — the only new symbol backend 7.0.0 emits (napi::symbol_for_property!) is generated solely for Symbol.for keys, which src/js.rs doesn't use; it compiles against the locked napi 3.15.0.

Package From → To Tier Scope
napi-derive 3.6.13 → 3.7.0 minor (lockfile-only, node feature) proc-macro for the shipped Node addon
napi-derive-backend 6.1.6 → 7.0.0 major (transitive) same

Breaking for this repo: None found. Call sites: src/js.rs:151-322 (#[napi(object)] ×6, #[napi] class + methods, one #[napi(constructor)]).
Tests: cargo check --features node --locked ✓ · cargo test --features node --locked --lib -- js::tests ✓ (2/2) · cargo check --workspace --all-targets --locked ✓ · npm install && npm run build:debug && npm test ✓ (41/41) · combined with #191: all ✓ plus full cargo test --workspace --all-targets --locked ✓ (0 failed)
Supply chain: no flags (released 2026-10-30, not yanked, no new crates, MSRV 1.88 unchanged)

Details

backend 6.1.6→7.0.0 changes src/ast.rs, codegen.rs, codegen/struct.rs, typegen/{fn,struct}.rs: symbol-keyed class members (#3661, #3665) and the define_class closure / static-flag / TS1016 fix (#3662). Diffing every bindgen_prelude::* and napi::* path the backend emits, 7.0.0 adds only napi::symbol_for_property (a macro that exists only in napi ≥ 3.16.0) behind the Symbol.for key path — so the #184 skew hazard is real for anyone using that feature but not for this repo. Generated native.js/.d.ts export shape unchanged. Pairing with #191 (napi 3.16.0) is still the tidy outcome; grouping napi* in dependabot.yml would stop these arriving separately.

@dependabot @github

dependabot Bot commented on behalf of github Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

A newer version of napi-derive exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants