Skip to content

test: remove resolved command lookup difference marker - #315

Merged
gautamsirdeshmukh merged 1 commit into
strands-agents:mainfrom
ikenyal:test/remove-fixed-command-lookup-marker
Nov 18, 2026
Merged

gautamsirdeshmukh merged 1 commit into
strands-agents:mainfrom
ikenyal:test/remove-fixed-command-lookup-marker

Conversation

@ikenyal

@ikenyal ikenyal commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Description

#272 fixed command -v lookup for names containing a slash, but the differential case still marks that behavior as a known difference. The runner fails when a known difference starts matching Bash. Remove the stale marker so the existing case becomes a normal regression test.

This only deletes the marker line; the script, recorded output, and shell implementation are unchanged.

Related Issues

Follow-up to #272.

Documentation PR

Not needed; test fixture metadata only.

Type of Change

Other (please describe): test correction

Testing

  • I ran the relevant test suites for the bindings I touched (cargo test --workspace --all-targets, pytest tests/python, npm test)
  • If I touched Rust, I ran cargo fmt and cargo clippy

cargo test --locked --test differential fails on unchanged main because this case now matches Bash and passes after removing the marker. No Rust code or bindings are changed, so the Rust-source formatting/lint item is not applicable.

Checklist

  • I have read the CONTRIBUTING document
  • I have reviewed and understand every line of code in this PR, including any generated by AI tools, and I can explain why it works
  • My change is focused and reasonably small; I have split unrelated work into separate PRs
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Documentation changes are not applicable to this test-only correction.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions Bot added the chore Maintenance tasks, dependency updates, CI changes, refactoring with no user-facing impact label Nov 17, 2026
@gautamsirdeshmukh
gautamsirdeshmukh enabled auto-merge (squash) November 18, 2026 21:59
@gautamsirdeshmukh
gautamsirdeshmukh merged commit ccae0f8 into strands-agents:main Nov 18, 2026
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance tasks, dependency updates, CI changes, refactoring with no user-facing impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants