Skip to content

Preserve failure journals across repository test harnesses #1171

Open
1 of 1 issue completed
Open

Description

@taras

A failed repository test preserves the execution journals needed to diagnose it through the shared helper from #1169.

Current gap

Many tests and shared harnesses construct InMemoryStream directly. A fix limited to the CLI entrypoint leaves those execution paths without automatic failure artifacts and encourages each harness to implement its own dump logic.

Dependency and scope

Depends on #1169 establishing the shared helper and failure-only persistence contract.

Inventory repository test execution boundaries and their shared helpers, including direct core executions, Markdown testing harnesses, CLI/nested-child tests, and REPL testing. Migrate the common owners first, then the remaining direct execution sites. Reuse the shared helper and host persistence adapters.

An in-memory stream intentionally used to test journal mechanics or construct replay history is different from a harness running an execution. Record such retained uses with their reason; a raw constructor count alone does not establish completion.

Acceptance

  • Every test execution boundary in the inventory uses the shared failure-journal helper or has a documented, reviewed reason for retaining a deliberate journal fixture.
  • A failure in harness assertions after document execution still preserves the corresponding journal.
  • Nested and concurrent executions retain distinct, identifiable files.
  • Successful tests perform no automatic journal filesystem writes; no per-event or periodic flush is introduced.
  • Failure and timeout artifacts are discoverable and reach CI artifact upload.
  • Preserve existing scenarios, assertions, expected failures, replay histories, runtime coverage, deadlines, and joined teardown. Migration does not suppress failures or change what a test proves.
  • Representative direct-execution, nested-child, and REPL cases demonstrate retained traces through their real harness boundaries.
  • The final inventory names the migrated owners and the justified remaining direct constructions.

Delivery

Migrate through the Planner/Implementor workflow using focused evidence and independent review. Broad adoption starts after the shared helper's API and initial real consumers are validated; this ticket does not authorize treating the current uncommitted draft as accepted implementation.

Live stderr progress is tracked separately in #1170.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions