Skip to content

Preserve mounted REPL journals when tests fail #1398

Closed

Description

@taras

Mounted REPL test failures preserve the entry and Sidekick journals that the real fixture wrote, with the failing case's identity, before temporary session directories are removed.

This is a coverage gap under #1171. The mounted page fixture uses a real file-backed paired REPL repository. Its temporary-directory cleanup currently deletes those journals after assertion failures and observable timeout cleanup. The existing in-memory journal adoption does not cover this owner.

Acceptance:

  • A post-execution assertion failure preserves the actual paired journals and identifies the case and each execution.
  • Observable timeout or cancellation cleanup saves the available journals before removing fixture storage, with existing deadlines and joined teardown preserved.
  • Multiple and nested session traces remain distinct and identifiable.
  • Passing cases add no uploaded failure artifacts. Capture adds no periodic or per-event persistence.
  • Focused real mounted-fixture witnesses cover Deno, Node and Bun through the shared test-support APIs, using ordinary it declarations and existing ownership and replay behavior.

The failing Bun lifecycle job that exposed the gap is https://github.com/taras/executable.md/actions/runs/44180778062/job/134384198741. Its uploaded artifact contains other tests' journals, leaving these mounted lifecycle failures without their session traces.

The Round UI-specific lifecycle repairs depend on #1387 and remain a separate change. This issue's fixture repair is based on main and closes after its reviewed PR merges. No production personal REPL history is used as test evidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions