Skip to content

Combine duplicate approved-Plan test journeys - #1188

Merged
taras merged 3 commits into
mainfrom
codex/consolidate-plan-approval-tests
Nov 8, 2026
Merged

taras merged 3 commits into
mainfrom
codex/consolidate-plan-approval-tests

Conversation

@taras

@taras taras commented Nov 8, 2026 •

Copy link
Copy Markdown
Owner

Why

The first two Plan Markdown tests run the same document, scripted scenario and approval twice. Check returned source and nonexecution after one journey.

What changes

The first Test retains its successful Execution and both source-output assertions. Its planned.txt absence check now runs after that Execution closes. The repeated second Test is removed.

Only packages/cli/tests/document-suites/plan/Plan.test.md changes. The first execution and all later cases are byte-identical; fixtures, carrier and retained deadlines stay unchanged.

How to verify it

At signed feedback 05b01676aaa5f7c90a561e153a41c221390ae5e7:

  • The focused plan-markdown.test.ts carrier passed before and after; the Markdown suite changes from seven Tests to six.
  • Matching frozen carrier checks passed outside both timings.
  • A temporary child-side marker write made the retained first Test fail its moved zero-length assertion with actual 1 versus expected 0, after the successful source checks. Four later rows also observed the marker. The original fixture was restored and the newly created marker removed.
  • Retained Planner acceptance and independent Codex gpt-6-astra review both PASS on this exact commit, with no findings.

Risks and limitations

Two identical TestAgent partitions become one. An early source assertion failure now prevents the later file check in the same Test; no original assertion compared the independent partitions. The guard retains its original regular-file-only meaning.

One local wall-clock pair was 116.750s before and 113.186s after: 3.564s less observed. Both runs had matching type-check preparation. The timer records epoch wall time, and cache/order/load effects remain uncontrolled; this is not a stable CI saving or weight measurement.

No production API, helper, discovery file, runtime exclusion, dependency or timeout policy changes. Required CI remains authoritative; weights come only from a coherent hosted measurement.

Scope confirmation

  • One Markdown file; every distinct successful-journey assertion remains.
  • No unrelated cleanup or new testing infrastructure.
  • Temporary mutation and marker are absent from the commit.
  • Validation limits and consolidation tradeoffs are stated.

Closes #1186.

Delivery refresh: signed merge 982baab8ebf5d980deec974832b8d18654357936 incorporates current main 23c9003, including the reviewed CI repairs and the documentation update required by strict branch protection. Relative to main, only the original Plan test file differs; its reviewed blob remains 2b8d62b7114d5e68aa1316d2424e9e75c2c93b84. The previous CI run passed. Final CI on the updated branch passed: all required checks succeeded, with only the expected ordinary-PR composability skip. The automated PR Review also passed. GitHub reported the PR clean and mergeable before it merged. Post-merge CI on main 0ef868f also passed all required checks, along with the draft release.

The approved-Plan test and the nonexecution test ran the same child with
the same scenario and answer. The nonexecution guard now follows the first
journey's Execution, and the duplicate journey is removed.

Refs #1186

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown

PR #1188: Combine duplicate approved-Plan test journeys

1 files, +4 / -26

Scope

✅ PR scope looks good.

Structural

✅ No structural bloat detected.

Slop

✅ Slop indicators look low.

Static Analysis

✅ Oxlint found no issues.

Correctness

No extraneous code patterns detected.

@taras
taras marked this pull request as ready for review November 8, 2026 18:03
@taras
taras enabled auto-merge (squash) November 8, 2026 18:04
@taras
taras disabled auto-merge November 8, 2026 18:04
@taras
taras merged commit c26feb2 into main Nov 8, 2026
64 checks passed
@taras
taras deleted the codex/consolidate-plan-approval-tests branch November 8, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check approved Plan source and nonexecution in one journey

1 participant