Repository navigation
Combine duplicate approved-Plan test journeys - #1188
Merged
Merged
Conversation
The approved-Plan test and the nonexecution test ran the same child with the same scenario and answer. The nonexecution guard now follows the first journey's Execution, and the duplicate journey is removed. Refs #1186 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PR #1188: Combine duplicate approved-Plan test journeys1 files, +4 / -26 Scope✅ PR scope looks good. Structural✅ No structural bloat detected. Slop✅ Slop indicators look low. Static Analysis✅ Oxlint found no issues. CorrectnessNo extraneous code patterns detected. |
taras
marked this pull request as ready for review
November 8, 2026 18:03
taras
enabled auto-merge (squash)
November 8, 2026 18:04
taras
disabled auto-merge
November 8, 2026 18:04
…-refresh-1188-05b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The first two Plan Markdown tests run the same document, scripted scenario and approval twice. Check returned source and nonexecution after one journey.
What changes
The first Test retains its successful Execution and both source-output assertions. Its
planned.txtabsence check now runs after that Execution closes. The repeated second Test is removed.Only
packages/cli/tests/document-suites/plan/Plan.test.mdchanges. The first execution and all later cases are byte-identical; fixtures, carrier and retained deadlines stay unchanged.How to verify it
At signed feedback
05b01676aaa5f7c90a561e153a41c221390ae5e7:plan-markdown.test.tscarrier passed before and after; the Markdown suite changes from seven Tests to six.gpt-6-astrareview both PASS on this exact commit, with no findings.Risks and limitations
Two identical TestAgent partitions become one. An early source assertion failure now prevents the later file check in the same Test; no original assertion compared the independent partitions. The guard retains its original regular-file-only meaning.
One local wall-clock pair was 116.750s before and 113.186s after: 3.564s less observed. Both runs had matching type-check preparation. The timer records epoch wall time, and cache/order/load effects remain uncontrolled; this is not a stable CI saving or weight measurement.
No production API, helper, discovery file, runtime exclusion, dependency or timeout policy changes. Required CI remains authoritative; weights come only from a coherent hosted measurement.
Scope confirmation
Closes #1186.
Delivery refresh: signed merge
982baab8ebf5d980deec974832b8d18654357936incorporates current main23c9003, including the reviewed CI repairs and the documentation update required by strict branch protection. Relative to main, only the original Plan test file differs; its reviewed blob remains2b8d62b7114d5e68aa1316d2424e9e75c2c93b84. The previous CI run passed. Final CI on the updated branch passed: all required checks succeeded, with only the expected ordinary-PR composability skip. The automated PR Review also passed. GitHub reported the PR clean and mergeable before it merged. Post-merge CI on main0ef868falso passed all required checks, along with the draft release.