Repository navigation
Fix Preparation deadlines and preserve test failure diagnostics - #1192
Merged
Merged
Conversation
PR #1192: Fix Preparation deadlines and preserve test failure diagnostics7 files, +270 / -93 Scope✅ PR scope looks good. Structural✅ No structural bloat detected. Slop✅ Slop indicators look low. Static AnalysisOxlint: 3 diagnostics across 2 files (3 rules) consistent-function-scoping (1): packages/cli/src/test-diagnostics.ts CorrectnessNo extraneous code patterns detected. |
taras
marked this pull request as ready for review
November 8, 2026 16:33
This was referenced Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Preparation fails on current main because six independent journeys share one 180-second Test deadline. The failure blocks the cleanup PRs #1182 and #1188. Captured Bun errors can also lose their messages when their stack omits that text.
What changes
Ticket.Capturepreserves explicit error and cause messages alongside stack information.This is a test-boundary and diagnostics repair. It makes no execution-speed claim and introduces no public API.
How to verify it
Focused evidence for signed head
5a473210abfc65f701efbe800fcc797b44fe0c43(the three original A+B files are byte-identical to the testedf66053adcandidate):5a473210. The original attribution finding and the failing regression on its parent remain recorded.Scope and limits
Five source/test files change. The optional concise-output draft remains separate. Historical Implementation and Delivery failures remain unresolved observations; their current-main shards passed, and this PR makes no causal-fix claim for them.
Refs #1117 and main-health #1189.
Delivery: CI run 42499981144 passed all 62 jobs on exact head
5a473210, including composability underci-main-red-fix. PR Review also passed. GitHub reports this revision mergeable with a clean merge state.