Skip to content

Fix Preparation deadlines and preserve test failure diagnostics - #1192

Merged
taras merged 4 commits into
mainfrom
codex/ci-diagnostics-repair-1182-1188
Nov 8, 2026
Merged

taras merged 4 commits into
mainfrom
codex/ci-diagnostics-repair-1182-1188

Conversation

@taras

@taras taras commented Nov 8, 2026 •

Copy link
Copy Markdown
Owner

Why

Preparation fails on current main because six independent journeys share one 180-second Test deadline. The failure blocks the cleanup PRs #1182 and #1188. Captured Bun errors can also lose their messages when their stack omits that text.

What changes

  • Each of the six existing Preparation variants has its own named 180-second Test. Their bodies and assertions stay intact; the enclosing 330-second and 420-second limits remain.
  • Ticket.Capture preserves explicit error and cause messages alongside stack information.
  • Delayed test results retain the correct interruption metadata when named tests share a source location.

This is a test-boundary and diagnostics repair. It makes no execution-speed claim and introduces no public API.

How to verify it

Focused evidence for signed head 5a473210abfc65f701efbe800fcc797b44fe0c43 (the three original A+B files are byte-identical to the tested f66053ad candidate):

  • ProductionRole passes under Bun and Deno, including a controlled error/cause whose defined stacks omit their messages and the original unknown-provider refusal.
  • The full Preparation integration carrier passes. Its six original variants and final D C case remain in source; the nested command exits zero.
  • Final-head lint, typecheck, and JSR publishability pass.
  • Deno and Bun diagnostics pass. The new same-location pass/timeout/pass regression fails on the parent before the attribution correction and passes afterward.
  • Retained Planner acceptance and independent Codex Astra review both pass on exact head 5a473210. The original attribution finding and the failing regression on its parent remain recorded.

Scope and limits

Five source/test files change. The optional concise-output draft remains separate. Historical Implementation and Delivery failures remain unresolved observations; their current-main shards passed, and this PR makes no causal-fix claim for them.

Refs #1117 and main-health #1189.

Delivery: CI run 42499981144 passed all 62 jobs on exact head 5a473210, including composability under ci-main-red-fix. PR Review also passed. GitHub reports this revision mergeable with a clean merge state.

@taras taras added the ci-main-red-fix Maintainer-controlled: lands one PR while main is red, only with the full clean-checkout proof label Nov 8, 2026 — with ChatGPT Codex Connector
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

PR #1192: Fix Preparation deadlines and preserve test failure diagnostics

7 files, +270 / -93

Scope

✅ PR scope looks good.

Structural

✅ No structural bloat detected.

Slop

✅ Slop indicators look low.

Static Analysis

Oxlint: 3 diagnostics across 2 files (3 rules)
Density: 0.011 violations/added-line

consistent-function-scoping (1): packages/cli/src/test-diagnostics.ts
no-base-to-string (1): examples/adversarial-implementation/components/Ticket/Capture.ts
no-floating-promises (1): packages/cli/src/test-diagnostics.ts

Correctness

No extraneous code patterns detected.

@taras
taras marked this pull request as ready for review November 8, 2026 16:33
@taras
taras merged commit 6d34237 into main Nov 8, 2026
19 of 63 checks passed
@taras
taras deleted the codex/ci-diagnostics-repair-1182-1188 branch November 8, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-main-red-fix Maintainer-controlled: lands one PR while main is red, only with the full clean-checkout proof

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant