Repository navigation
Retain local test journals through workspace teardown - #1362
Merged
Merged
Conversation
3 tasks done
taras
added a commit
that referenced
this pull request
Nov 17, 2026
taras
added a commit
that referenced
this pull request
Nov 17, 2026
taras
added a commit
that referenced
this pull request
Nov 17, 2026
taras
added a commit
that referenced
this pull request
Nov 17, 2026
Replay the reviewed #1362 patch onto current main.
taras
force-pushed
the
codex/1171-local-artifact-and-fixtures
branch
from
November 17, 2026 20:05
c37cfc4 to
cd1f097
Compare
taras
added a commit
that referenced
this pull request
Nov 17, 2026
taras
marked this pull request as ready for review
November 17, 2026 21:26
taras
enabled stacked auto-merge (squash)
November 17, 2026 21:27
taras
disabled stacked auto-merge
November 17, 2026 21:27
taras
added a commit
that referenced
this pull request
Nov 18, 2026
…t journals (#1365) * test: attribute failure journals to declaring cases * test: capture failure journals for Testing document cases * test: capture failure journals for live WebForm cases * test: capture failure journals for held Core hosts * test: retain the ORC12 child journal for parent failures * test: attribute journals in ordinary Git execution cases * test: attribute journals in direct Core document cases * test: attribute failure journals for live synthetic REPL entries * test: attribute guarded ACP and TestAgent execution journals * test: attribute safe Agent and nested Testing execution journals * test: attribute fresh REPL observation entry journals * test: capture additional direct Core execution journals * test: attribute fresh workflow observation journals * test: attribute fresh CLI and Testing execution journals * test: attribute fresh Git issue scenario journals * test: retain separate CLI assembly journals for parent failures * test: attribute guarded CLI host and upgrade journals * test: attribute guarded Agent provider and usage journals * test: attribute fresh Answers, Elicit and Fail fixture journals * test: attribute fresh TestAgent component and launch journals * test: capture fresh inline REPL selection journals * test: capture guarded Glob fixture journals * test: attribute guarded Agent function component journals * test: retain separate journals for Testing session siblings * test: capture guarded Core prop evaluation journals * test: preserve independently bounded subprocess journals * test: capture additional held host and hook journals * test: capture guarded root comparisons and eval lifetimes * test: capture complete Testing activation sessions * test: attribute guarded exec timeout fixture journals * test: retain the activation expiry fixture journal * test: attribute guarded Core document helpers * test: attribute guarded Agent package execution controls * test: attribute guarded Git and Workflow host probes * test: attribute guarded Plan and Upgrade documents * test: attribute fresh REPL source ownership runs * test: attribute fresh Git binding and Issue envelopes * test: attribute fresh Workflow and Testing journals * test: preserve both workflow inputs in identity comparison * test: attribute fresh Core execution and comparison owners * test: attribute joined read-only component subprocess journals * test: attribute loader comparisons and a fresh REPL refusal * test: attribute independent Git reconciliation runs * test: attribute execution init and component fixture journals * test: capture Testing activation and Workflow observation cases * test: capture Git observation and owned-effect fixtures * test: capture fresh REPL history head entries * test: attribute contextual cwd and validation comparison journals * test: capture fresh REPL lifecycle entries * test: complete guarded binding and failure fixture coverage * Attribute filesystem and generated document test failures * Attribute inline roots and fresh CLI TODO executions * Attribute single-entry REPL lifecycle checks * Attribute REPL component lookup executions * Keep the GO11 Git assertion inside journal capture * Attribute fresh Core target and protocol executions * Attribute fresh service and ticket checkout test roots * Complete capture for mixed Core document fixtures * Attribute generated selection pairs and recovery guide test * Attribute ordinary Deno composition test roots * Attribute syntax, metadata, and loaded-copy document tests * Attribute delete, REPL focus, and evidence publication fixtures * Attribute fresh named-slot and expansion identity roots * Retain both TX6 journals at the caller artifact root * Attribute the remaining guarded generated-selection probes * Attribute guarded Evaluate and Syntax loaded-copy tests * Attribute portable CLI composition refusals and filesystem controls * Attribute remaining fresh Agent component roots * Attribute fresh Testing, TestAgent and pull request reads * Capture ACP cancellation and fresh Git scenario sessions * Capture guarded Agent configuration, routing and usage * Capture File.Delete refusal arms through cumulative checks * Attribute guarded Core filesystem and component cases * Attribute paired registration and filesystem roots * Give each CIV26 delegation variant a fresh journal * Adopt shared journals in Core evaluator tests * Adopt shared journal resource in Each tests * Use shared failure journal package in evaluator cases * Migrate Core cases to shared journal resource * test: adopt shared journal resource in #1356 consumers * Use package journal entry in Core stream tests * migrate #1357 ordinary journal cases to shared fixtures * Migrate compiler boundary cases to shared failure journal * Use shared journal package imports in #1359 tests * Use shared journal fixture in testing boundary cases * Use shared journal fixture for checkpoint case * Format #1356 shared journal tests * Migrate eligible journal owners to shared fixtures * Migrate #1361 journal fixtures to shared support * Restore #1359 journal ownership for nested tests * Adopt shared failure journal in PR 1360 suites * Migrate #1362 fresh journal fixtures * Restore attributed owners in Core journal suites * fix(core): restore D5 failure journal ownership * Restore failure journals in PR 1360 cases * test: migrate remaining agent git journal owners * revert(test): keep native launch outside agent migration * Capture journals in every ORC2 suite * Adopt the shared journal in filesystem test fixtures * Restore direct it registration in Core held-host tests * Migrate assert throws journal ownership * Migrate testing boundary journal owner * Restore direct test declarations in Agent, REPL and Web * Migrate testing boundary contract cases * Migrate test component journal cases * Migrate use testing journal cases * Keep ordinary test declarations in two Testing suites * Migrate workflow generated observation cases * Remove unused journal case registrar * Remove unused testing case registrar * Restore direct it registration in Git tests * Restore direct Glob and TestAgent test declarations * Restore direct test declarations in #1358 suites * Restore direct declarations for held-host cases * Restore direct Git and Workflow test declarations * Keep direct Testing declarations in the #1359 overlap * Restore direct REPL and Cwd test declarations * Keep File.Delete test declarations direct * Acquire journals in ordinary filesystem and component tests * Record the actual halted document source in RV12 journals * Capture failure journals for Agent, Testing and Git test owners Replay the reviewed #1363 patch onto current main. * Capture failure journals for Agent, Testing and Git test owners Replay the reviewed #1363 patch onto current main. --------- Co-authored-by: Luna <luna@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A Core comparison can save a journal inside its temporary workspace, then lose it when the workspace is removed. The capture now keeps both journals in the caller's artifact directory. Advances #1171 and builds on #1361.
What changes
Review guide
Start with
packages/core/tests/document-target-execution.test.tsand its default-path fault witness. The stage also addresses Fable's generated-selection findings from #1361.How to verify it
XMD_TEST_ARTIFACTSunset, the injected late failure retained both six-record journals and their correct sidecars after workspace removal. The passing control wrote no artifacts. Fable reproduced this independently.8654eaac.Scope
The broader migration remains open in #1171. The inventory is being reconciled for remaining File.Delete arms and other partially migrated owners.
Scope confirmation