Skip to content

Attribute Agent, Testing, and Git owner journals - #1363

Merged
taras merged 1 commit into
mainfrom
codex/1171-agent-testing-git-owners
Nov 18, 2026
Merged

taras merged 1 commit into
mainfrom
codex/1171-agent-testing-git-owners

Conversation

@taras

@taras taras commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Why

Fresh Agent, ACP, Testing and Git executions need their journals when an assertion fails after execution. This stage of #1171 adds case-attributed capture through the shared failure-only resource, building on merged #1362.

What changes

Before: these guarded execution paths could finish before a later assertion exposed a failure, leaving their journals unavailable.

After: ordinary it cases use the suite's beforeEach resource. Eligible executions retain their journals through joined cleanup and assertions. Supplied, replay, seeded, raw and protected fixtures keep their existing ownership. Passing tests produce no automatic journal artifacts.

The rebase preserves the previously reviewed eight-file migration patch. Existing scenarios, assertions, deadlines and teardown are unchanged.

Review guide

Start with the ACP cancellation case and the independent document sessions in packages/git/tests/issue-markdown.test.ts, then the Agent/TestAgent and Testing consumers.

How to verify it

  • Focused Deno: 33 tests and 252 steps passed.
  • Pinned Node 22.23.4 and Bun 1.4.0: 212 tests passed under each runtime.
  • Scoped formatting and whitespace checks passed.
  • Those commands ran on Luna's signed feedback candidate a47ba506e4084ce8b143a6fbd39e009a233262ab. It has the same parent and complete source tree as the maintainer's delivery 97ad98e41d5636fdee968f9996cafc0fd8e8e24b; the original receipts remain attributed to the tested candidate.
  • The retained Planner and original independent Codex Astra both PASS on exact delivery 97ad98e4. The Planner also verified preservation of all 809 expectation expressions and zero registering aliases.
  • Required CI 44308400840 runs on the actual delivery commit. Its final result remains a merge gate.

Scope

This PR covers the eight existing adoption files. Remaining migrations and justified explicit journal fixtures stay tracked in #1171.

Scope confirmation

  • Every changed file supports this adoption.
  • Unrelated cleanup is excluded.
  • The description matches the current source and focused verification.

taras added a commit that referenced this pull request Nov 17, 2026
taras added a commit that referenced this pull request Nov 17, 2026
@taras
taras added this pull request to stack #1386 November 17, 2026 12:00
taras added a commit that referenced this pull request Nov 17, 2026
Base automatically changed from codex/1171-local-artifact-and-fixtures to main November 17, 2026 21:27
@taras
taras force-pushed the codex/1171-agent-testing-git-owners branch from c21d696 to df5ce08 Compare November 17, 2026 21:30
taras added a commit that referenced this pull request Nov 17, 2026
@taras
taras marked this pull request as ready for review November 17, 2026 21:30
taras added a commit that referenced this pull request Nov 18, 2026
Replay the reviewed #1363 patch onto current main.
@taras
taras force-pushed the codex/1171-agent-testing-git-owners branch from df5ce08 to bc0823c Compare November 18, 2026 08:03
Replay the reviewed #1363 patch onto current main.
@taras
taras force-pushed the codex/1171-agent-testing-git-owners branch from bc0823c to 97ad98e Compare November 18, 2026 12:54

taras commented Nov 18, 2026

Copy link
Copy Markdown
Owner Author

Retained independent Codex Astra (gpt-6-astra) review: PASS on your exact rebased head 97ad98e41d5636fdee968f9996cafc0fd8e8e24b, with no blocking findings. The original reviewer conversation was resumed; no replacement reviewer was created. Receipt SHA-256: c58e61508cb858ec1463426eab4695e0da44ecee2511e3159e0f4196f5915ca5.

The reviewer confirmed that your delivery commit and Luna's signed feedback candidate a47ba506 have the same parent and complete source tree, and that the eight adoption files retain the previously reviewed patch. It inspected the intervening shared-fixture changes and confirmed case attribution, failure-only persistence, supplied/private/replay ownership and joined cleanup remain intact.

Focused evidence was reused truthfully from a47ba506: Deno 33 tests/252 steps, Node 212 tests and Bun 212 tests passed. Those receipts remain attributed to that tested candidate; they were not relabeled as executions on 97ad98e4. Required CI runs on your actual rebased commit. Planner reconciliation and delivery checks are tracked separately from this independent PASS.

@taras
taras merged commit 495b112 into main Nov 18, 2026
64 checks passed
@taras
taras deleted the codex/1171-agent-testing-git-owners branch November 18, 2026 13:13
taras added a commit that referenced this pull request Nov 18, 2026
…t journals (#1365)

* test: attribute failure journals to declaring cases

* test: capture failure journals for Testing document cases

* test: capture failure journals for live WebForm cases

* test: capture failure journals for held Core hosts

* test: retain the ORC12 child journal for parent failures

* test: attribute journals in ordinary Git execution cases

* test: attribute journals in direct Core document cases

* test: attribute failure journals for live synthetic REPL entries

* test: attribute guarded ACP and TestAgent execution journals

* test: attribute safe Agent and nested Testing execution journals

* test: attribute fresh REPL observation entry journals

* test: capture additional direct Core execution journals

* test: attribute fresh workflow observation journals

* test: attribute fresh CLI and Testing execution journals

* test: attribute fresh Git issue scenario journals

* test: retain separate CLI assembly journals for parent failures

* test: attribute guarded CLI host and upgrade journals

* test: attribute guarded Agent provider and usage journals

* test: attribute fresh Answers, Elicit and Fail fixture journals

* test: attribute fresh TestAgent component and launch journals

* test: capture fresh inline REPL selection journals

* test: capture guarded Glob fixture journals

* test: attribute guarded Agent function component journals

* test: retain separate journals for Testing session siblings

* test: capture guarded Core prop evaluation journals

* test: preserve independently bounded subprocess journals

* test: capture additional held host and hook journals

* test: capture guarded root comparisons and eval lifetimes

* test: capture complete Testing activation sessions

* test: attribute guarded exec timeout fixture journals

* test: retain the activation expiry fixture journal

* test: attribute guarded Core document helpers

* test: attribute guarded Agent package execution controls

* test: attribute guarded Git and Workflow host probes

* test: attribute guarded Plan and Upgrade documents

* test: attribute fresh REPL source ownership runs

* test: attribute fresh Git binding and Issue envelopes

* test: attribute fresh Workflow and Testing journals

* test: preserve both workflow inputs in identity comparison

* test: attribute fresh Core execution and comparison owners

* test: attribute joined read-only component subprocess journals

* test: attribute loader comparisons and a fresh REPL refusal

* test: attribute independent Git reconciliation runs

* test: attribute execution init and component fixture journals

* test: capture Testing activation and Workflow observation cases

* test: capture Git observation and owned-effect fixtures

* test: capture fresh REPL history head entries

* test: attribute contextual cwd and validation comparison journals

* test: capture fresh REPL lifecycle entries

* test: complete guarded binding and failure fixture coverage

* Attribute filesystem and generated document test failures

* Attribute inline roots and fresh CLI TODO executions

* Attribute single-entry REPL lifecycle checks

* Attribute REPL component lookup executions

* Keep the GO11 Git assertion inside journal capture

* Attribute fresh Core target and protocol executions

* Attribute fresh service and ticket checkout test roots

* Complete capture for mixed Core document fixtures

* Attribute generated selection pairs and recovery guide test

* Attribute ordinary Deno composition test roots

* Attribute syntax, metadata, and loaded-copy document tests

* Attribute delete, REPL focus, and evidence publication fixtures

* Attribute fresh named-slot and expansion identity roots

* Retain both TX6 journals at the caller artifact root

* Attribute the remaining guarded generated-selection probes

* Attribute guarded Evaluate and Syntax loaded-copy tests

* Attribute portable CLI composition refusals and filesystem controls

* Attribute remaining fresh Agent component roots

* Attribute fresh Testing, TestAgent and pull request reads

* Capture ACP cancellation and fresh Git scenario sessions

* Capture guarded Agent configuration, routing and usage

* Capture File.Delete refusal arms through cumulative checks

* Attribute guarded Core filesystem and component cases

* Attribute paired registration and filesystem roots

* Give each CIV26 delegation variant a fresh journal

* Adopt shared journals in Core evaluator tests

* Adopt shared journal resource in Each tests

* Use shared failure journal package in evaluator cases

* Migrate Core cases to shared journal resource

* test: adopt shared journal resource in #1356 consumers

* Use package journal entry in Core stream tests

* migrate #1357 ordinary journal cases to shared fixtures

* Migrate compiler boundary cases to shared failure journal

* Use shared journal package imports in #1359 tests

* Use shared journal fixture in testing boundary cases

* Use shared journal fixture for checkpoint case

* Format #1356 shared journal tests

* Migrate eligible journal owners to shared fixtures

* Migrate #1361 journal fixtures to shared support

* Restore #1359 journal ownership for nested tests

* Adopt shared failure journal in PR 1360 suites

* Migrate #1362 fresh journal fixtures

* Restore attributed owners in Core journal suites

* fix(core): restore D5 failure journal ownership

* Restore failure journals in PR 1360 cases

* test: migrate remaining agent git journal owners

* revert(test): keep native launch outside agent migration

* Capture journals in every ORC2 suite

* Adopt the shared journal in filesystem test fixtures

* Restore direct it registration in Core held-host tests

* Migrate assert throws journal ownership

* Migrate testing boundary journal owner

* Restore direct test declarations in Agent, REPL and Web

* Migrate testing boundary contract cases

* Migrate test component journal cases

* Migrate use testing journal cases

* Keep ordinary test declarations in two Testing suites

* Migrate workflow generated observation cases

* Remove unused journal case registrar

* Remove unused testing case registrar

* Restore direct it registration in Git tests

* Restore direct Glob and TestAgent test declarations

* Restore direct test declarations in #1358 suites

* Restore direct declarations for held-host cases

* Restore direct Git and Workflow test declarations

* Keep direct Testing declarations in the #1359 overlap

* Restore direct REPL and Cwd test declarations

* Keep File.Delete test declarations direct

* Acquire journals in ordinary filesystem and component tests

* Record the actual halted document source in RV12 journals

* Capture failure journals for Agent, Testing and Git test owners

Replay the reviewed #1363 patch onto current main.

* Capture failure journals for Agent, Testing and Git test owners

Replay the reviewed #1363 patch onto current main.

---------

Co-authored-by: Luna <luna@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant