Repository navigation
Open and send drafts from the REPL Round editor - #1387
Conversation
taras
left a comment
There was a problem hiding this comment.
Independent workflow review
PASS for aa00d948d1f45b4269665f150c6855ff26dfbfc0.
Reviewer codex / gpt-6-astra, the recorded Fable fallback, in rounds-01-05-v10-first-independent-review-astra.
Reviewed the exact clean revision against all three original acceptance clauses and the recorded visual approvals. The test migration resolves the prior blocking failures while preserving source, attribution, reservation, journal and retained-text assertions. Reused exact-head evidence: 44 tests and 173 steps passed across both affected suites, five Markdown Bench journeys and both preflight children exited successfully, and refreshed captures and paired timings are retained. No blocking correctness finding remains. Source stayed unchanged; all processes started during this review completed. No additional runtime suites or CI waits were needed.
-
The prior consumer-migration finding is resolved. Manual submission now focuses Send before Enter; frozen-history submission exercises an actual Send refusal; closed and open editor states have distinct assertions; Transcript and Sidekick queries use their respective panes. The exact-head final-journey.log reports 20 tests and 76 steps passing, and final-presentation.log reports 24 tests and 97 steps passing. The changes preserve the substantive assertions that previously could not execute.
-
The exact-head Bench journey covers pointer and keyboard opening and Send, editor newline, direct Tab focus, empty Send, narrow routing, running History and Transcript cues, Stop, and unsent Message preservation. Refreshed visual evidence follows the recorded approvals for the outlined editor, placeholder, narrow heading states, control placement and running treatment. Publication inputs remain a template requiring the coordinator's actual PR target and comparison metadata; publication itself is outside this review.
-
Paired mounted Message timings show no material regression: baseline/candidate median and p95 are 10.76/11.36 versus 10.98/12.06 ms for two rounds, and 19.41/20.61 versus 17.32/18.70 ms for 52 wrapping rounds. This correction changes test code only. The measurements cover ordinary Message typing, not editor-focus transition latency.
The review and the nine Reference / Before / After comparisons in this description cover aa00d948d1f45b4269665f150c6855ff26dfbfc0. Subsequent commits require their own validation.
taras
left a comment
There was a problem hiding this comment.
Independent workflow review
PASS for afd05c17b3d2d0d7fddd6a94e39eebbb139e9869.
Reviewer codex / gpt-6-astra, the recorded Fable fallback, in rounds-01-05-v10-first-independent-review-astra.
Reviewed the exact clean revision against all three original acceptance clauses and recorded visual approvals. The test migrations preserve substantive assertions while using the current Round controls and measured presentation boundaries. The removed layout helpers have no remaining consumers. Reused exact-head focused runtime checks, five successful Markdown Bench launches, two successful preflight launches, refreshed captures and paired timings. No blocking correctness finding remains. Source stayed unchanged; every process started during this review completed. No broad suites or CI waits were performed.
-
The migrated tests retain their meaningful checks: exact submitted source, recovery placement and permissions, caret preservation, modal isolation, History selection, and interaction-cost bounds. Cost sampling now waits for the requested edit or focus change rather than any intervening frame. Retained exact-head evidence shows the nine-file batch and interaction-cost/Exit group passing under Deno, Bun and Node; both include PTY cases pass under Deno, Bun and Node 22.23.2.
-
Preserve the Node 26.5.1 limitation: exact-include-node.log records SO3–SO4 timing out with a localStorage warning embedded in the terminal frame, while the pinned baseline passed. This evidence does not isolate the cause, and the Node 22 pass does not establish Node 26 compatibility. The checked-in hosted runtime is Node 22.23.4; no Node 26 success is claimed by this verdict.
-
Fresh evidence binds all nine visual checkpoints to this candidate and the approved baseline. The inspected captures retain the outlined editor, placeholder, approved narrow heading behavior, focused Send, running controls, History and Transcript cues. Paired Message typing median/p95 improved from 10.59/11.35 to 10.33/11.19 ms for two rounds and from 17.96/19.78 to 17.59/18.82 ms for 52 wrapping rounds. Publication still requires coordinator-owned comparison metadata; the partial packet validation is not a completed publisher dry-run.
taras
left a comment
There was a problem hiding this comment.
Independent workflow review
PASS for e627928bcc4b4896eb3795e236774dba6e613573.
Reviewer codex / gpt-6-astra, the recorded Fable fallback, in rounds-01-05-v10-first-independent-review-astra.
Reviewed the exact clean revision against all three original acceptance clauses and recorded visual approvals. The one-file test correction uses the actual Round editor and focused Send without weakening reservation or preservation assertions. Reused exact-head evidence: all 28 headless-submit cases pass under Deno, Bun and Node 22; five Markdown Bench launches and both preflight launches succeed. Refreshed visual checkpoints and paired timings are retained. No blocking correctness finding remains. Source stayed unchanged, and every process started during this review completed. No additional runtime suites or CI waits were needed.
-
The three missed consumers are correctly migrated. openHumanDraft clicks the rendered New Round control through the existing attachment input helper, which waits for accepted input and its completed frame, then verifies editor focus. Human submission verifies Send focus before Enter. Reservation exclusion, unchanged-screen refusal, human takeover, unsent Message, stale-history rejection and newer-draft preservation remain covered. Added entry-count and exact-source assertions distinguish genuine admission from an unrelated successful join.
-
Exact-candidate Bench evidence retains nine viewport/state comparisons against the pinned baseline and v10 references. The journey preserves both opening and Send gestures, newline, direct Tab focus, empty Send, running cues, Stop and Message preservation. Publication comparison metadata remains coordinator-owned; prepared-input validation is not a completed publisher dry-run.
-
The paired Message benchmark records baseline/candidate median and p95 of 10.99/11.60 versus 10.67/12.20 ms for two rounds, and 19.51/21.20 versus 17.90/18.76 ms for 52 wrapping rounds. The small-workload p95 increase is retained as an observation, not an established regression. This revision changes only test code.
M8's Control-C case asserted the Entries crumbs while the Round editor was open, so the failure was hidden behind the held provider cancellation until the 300s deadline. Release that hold when the test scope exits, and prove the entry is still the same running entry through the header status and the settled reading. The Follow case counted two global [stop] labels; the Round bar draws Stop beside + New Round. Scope the Sidekick Stop to its controls and the entry's Stop to the Round bar, including its retirement after settlement. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The lifecycle repair is ready at M8's obsolete Entries breadcrumb assertion threw while the new Round editor was open. Its test-owned cancellation hold was never released on failure, so teardown hid the assertion behind the 300-second deadline. Cleanup now releases that hold. Restoring the obsolete assertion in a fault probe reports the failure in 841 ms. The replacement assertion checks both the running Entry header and the durable entry identity. The Follow case now distinguishes Sidekick Independent Fable review: PASS on this exact commit. The review checked the cancellation cleanup, separate Stop owners, preserved Follow/Send assertions and supplied verification evidence. Focused checks passed on Bun 1.4.0 and Node 22.23.4 (43 cases each), and Deno 2.9.7 on the byte-identical candidate. Required CI also passed its pinned runtimes. Nonblocking review observation: the existing PV3 case also holds cancellation without failure-path cleanup. No failure was observed there; it was outside this causal repair. Mounted REPL journal preservation is being delivered separately under #1398 / #1171. This PR has not been merged by the repair coordinator. |
Why
The REPL’s small inline Draft made multi-line authoring awkward and used Enter for submission. A dedicated Round editor gives drafting and sending distinct controls while preserving the Sidekick Message.
What changes
+ New Roundat wide and narrow sizes. It uses the approved inset border and empty placeholder.Review guide
Review the editor and admission path against
specs/repl-spec.md, then inspect the test-consumer migration. The independent Codex Astra review passed exact commite627928bcc4b4896eb3795e236774dba6e613573.How to verify it
Affected hosted-test batches passed under Deno, Bun, and Node. Include PTY cases passed under Deno, Bun, and Node 22. The full Sidekick suites previously passed 44 tests and 173 steps at
aa00d948; their test files are retained by this child. Lint and whitespace checks passed on the hosted-test correction.Two preflight children and five Markdown Bench launches passed on the current head. The nine matched checkpoints cover Draft Open, Send Focus, and Running at 160×36, 120×30, and 72×20.
Scope
The visual Before remains the approved
1584a779ca2be585c419c574bef47f3405d7ac45. Reference images come from pinned v10. After captures and paired timings namee627928bcc4b4896eb3795e236774dba6e613573. The draft targets currentmain.Risks and limitations
A local Node 26.5.1 PTY run failed with a localStorage warning inside its terminal frame. Node 22.23.2 passed locally, and hosted CI uses Node 22.23.4. Node 26 compatibility remains unresolved.
Paired measurements cover mounted Message typing. Editor-focus transition latency was not measured.
Earlier validation
e1c8e289removes two unused layout exports. Full local lint and both Sidekick suites passed again on that commit (44 tests, 173 steps).Headless submission test migration
The three missed human-input paths in
repl-headless-submit.test.tsnow open + New Round and verify editor focus before typing. The person submitter focuses Send before Enter. Reservation, exact-source, takeover, unsent Message, and newer-draft assertions remain intact. All 28 cases passed under Bun, Deno, and Node 22 one627928bcc4b4896eb3795e236774dba6e613573. Planner and independent Astra reviews passed this exact commit. Only this test file changed in the correction.REPL UI evidence
Mounted typing latency
Viewport 200 × 52. Milliseconds from character dispatch to the completed emulator write containing the changed Message value.
Why
The REPL’s small inline Draft made multi-line authoring awkward and used Enter for submission. A dedicated Round editor gives drafting and sending distinct controls while preserving the Sidekick Message.
What changes
+ New Roundat wide and narrow sizes. It uses the approved inset border and empty placeholder.Review guide
Review the editor and admission path against
specs/repl-spec.md, then inspect the test-consumer migration. The independent Codex Astra review passed exact commite627928bcc4b4896eb3795e236774dba6e613573.How to verify it
Affected hosted-test batches passed under Deno, Bun, and Node. Include PTY cases passed under Deno, Bun, and Node 22. The full Sidekick suites previously passed 44 tests and 173 steps at
aa00d948; their test files are retained by this child. Lint and whitespace checks passed on the hosted-test correction.Two preflight children and five Markdown Bench launches passed on the current head. The nine matched checkpoints cover Draft Open, Send Focus, and Running at 160×36, 120×30, and 72×20.
Scope
The visual Before remains the approved
1584a779ca2be585c419c574bef47f3405d7ac45. Reference images come from pinned v10. After captures and paired timings namee627928bcc4b4896eb3795e236774dba6e613573. The draft targets currentmain.Risks and limitations
A local Node 26.5.1 PTY run failed with a localStorage warning inside its terminal frame. Node 22.23.2 passed locally, and hosted CI uses Node 22.23.4. Node 26 compatibility remains unresolved.
Paired measurements cover mounted Message typing. Editor-focus transition latency was not measured.
Earlier validation
e1c8e289removes two unused layout exports. Full local lint and both Sidekick suites passed again on that commit (44 tests, 173 steps).Headless submission test migration
The three missed human-input paths in
repl-headless-submit.test.tsnow open + New Round and verify editor focus before typing. The person submitter focuses Send before Enter. Reservation, exact-source, takeover, unsent Message, and newer-draft assertions remain intact. All 28 cases passed under Bun, Deno, and Node 22 one627928bcc4b4896eb3795e236774dba6e613573. Planner and independent Astra reviews passed this exact commit. Only this test file changed in the correction.