Repository navigation
Retain screened diagnostics when Sidekick resume fails - #1391
Conversation
|
Independent review PASS on Reviewed with Codex Astra Reviewed the exact assigned commit against ae7424a and examined all three acceptance clauses against the original implementation plan. No blocking correctness defect or material ambiguity found. Traced refusal classification, screened persistence, reconstruction, held replay, request association and recovery through affected consumers. Reused recorded focused tests, vendor validation and typecheck evidence, including the corrected refusal tests passing under Deno, Bun and Node. No additional test run was needed to distinguish a finding. Dependent presentation changes were excluded. Source remains unchanged; all commands started during this review completed. Required CI passed on this exact head in run 44128661346. |
|
|
||
| describe( | ||
| "a held Codex conversation across a host CLI upgrade", | ||
| "1388 — resume retention: a held Codex conversation across a host CLI upgrade", |
There was a problem hiding this comment.
do not include issue numbers in code
|
Fixed in Removed the Independent review: PASS on this exact commit, Codex Astra Focused validation passed:
#1392 is restacked on this head. Both PRs remain draft; required CI remains a merge gate. |
Why
A Sidekick reconnect can fail before the prompt reaches the adapter. XMD could report that resume failed while losing the adapter’s explanation and the failed attempt on reopen.
What changes
XMD retains a failed pre-prompt resume with the original conversation and the existing recovery message. It records a screened set of diagnostic fields when the adapter provides them. The dependent PR uses that record to show the detail in Sidekick chat.
How it works
The ACP provider classifies the refusal and selects bounded facts. The Agent screens those facts and records one failed attempt after the connection scope settles. Sidekick associates the attempt with its originating request and preserves the existing recovery choices.
Review guide
Start with the changes in
packages/agent/src/conversation.tsandpackages/acp/src/provider.ts. Follow the record throughpackages/agent/src/journal.tsand the Sidekick request association inpackages/cli/src/repl/sidekick/model.ts.How to verify it
The active-writer case was reproduced in a disposable conversation. The original intermittent incident remains unattributed.
Related to #1388.