Repository navigation
Show screened resume explanations in Sidekick - #1392
Conversation
e0384ed to
907b60c
Compare
|
Independent review PASS on Reviewed with Codex Astra Examined all three acceptance clauses against the original scope and owning ACP/REPL contracts. No blocking defect found. Traced rejected promptStarted, prompt ensure, and eager held-session ensure through diagnostic selection, screening, persistence, reconstruction, and live/reopened presentation. Actionable details survive; absent, blank, screened, and unselected details retain the readable fallback without exposing raw payloads. Identity and refusal controls remain intact. The shared prerequisite and presentation consumer are separate commits. Reused recorded successful evidence: seven released-runtime refusal cases, four mounted presentation cases, and seven recovery cases; the dependent receipts identify this exact revision. No new tests or CI checks were needed. All inspection processes completed, and the checkout remains unchanged. Non-blocking observations
This PR targets the prerequisite branch. The repository CI workflow selects PRs targeting main. Its mounted presentation and recovery checks passed locally at this exact head. The required CI run will follow retargeting after the prerequisite merges. |
907b60c to
f3d09c7
Compare
|
Restacked on corrected prerequisite #1391 at The presentation patch retains its previously reviewed behavior. Its only patch change is removing the issue-number prefix from the added test title, following the review feedback. The inherited prerequisite now owns early-resume mapping entirely in XMD and adds no vendored ACPX changes. Independent review: PASS on this exact head, Codex Astra The mounted presentation/recovery selection passes all eleven steps, including actionable, absent, blank and screened detail while live and after passive reopen. The prerequisite's Deno, Node, Bun, vendor and clean-checkout verification passed. This PR remains draft with its stacked base unchanged. |
f3d09c7 to
aa12dc0
Compare
Why
A generic resume failure tells a Sidekick user that the conversation stopped. An approved adapter explanation can tell them what happened and what to do next.
What changes
Sidekick shows the screened reconnect detail followed by the existing recovery message, both when the resume fails and after reopening the chat. With absent, blank, or screened-out detail, it shows the recovery message alone.
Review guide
Start with the shared text selection in
packages/cli/src/repl/sidekick/model.tsand its use inpackages/cli/src/repl/sidekick/owner.ts. This PR builds on the resume-retention prerequisite in #1391.How to verify it
The mounted Sidekick REPL test covers one failed chat attempt, matching live and reopened text, literal rendering, and fallback for absent, blank, and screened details. It also checks that reopening is passive and a later explicit send can reach the same saved conversation. The recovery regression and type checking passed.
Closes #1388.