Skip to content

Show screened resume explanations in Sidekick - #1392

Merged
taras merged 1 commit into
mainfrom
codex/resume-diagnostics-1388
Nov 17, 2026
Merged

taras merged 1 commit into
mainfrom
codex/resume-diagnostics-1388

Conversation

@taras

@taras taras commented Nov 17, 2026

Copy link
Copy Markdown
Owner

Why

A generic resume failure tells a Sidekick user that the conversation stopped. An approved adapter explanation can tell them what happened and what to do next.

What changes

Sidekick shows the screened reconnect detail followed by the existing recovery message, both when the resume fails and after reopening the chat. With absent, blank, or screened-out detail, it shows the recovery message alone.

Review guide

Start with the shared text selection in packages/cli/src/repl/sidekick/model.ts and its use in packages/cli/src/repl/sidekick/owner.ts. This PR builds on the resume-retention prerequisite in #1391.

How to verify it

The mounted Sidekick REPL test covers one failed chat attempt, matching live and reopened text, literal rendering, and fallback for absent, blank, and screened details. It also checks that reopening is passive and a later explicit send can reach the same saved conversation. The recovery regression and type checking passed.

Closes #1388.

@taras
taras force-pushed the codex/resume-diagnostics-1388 branch from e0384ed to 907b60c Compare November 17, 2026 16:41
@taras

taras commented Nov 17, 2026

Copy link
Copy Markdown
Owner Author

Independent review PASS on 907b60cf1ad957cf91456679eb76892210dc2257.

Reviewed with Codex Astra gpt-6-astra under the standing Fable fallback. Fable’s quota-limited earlier prerequisite attempt and the earlier dependent verdict remain retained separately. The corrected prerequisite fixes the Bun assertion mutation. The dependent diff remains byte-identical to the earlier presentation diff.

Examined all three acceptance clauses against the original scope and owning ACP/REPL contracts. No blocking defect found. Traced rejected promptStarted, prompt ensure, and eager held-session ensure through diagnostic selection, screening, persistence, reconstruction, and live/reopened presentation. Actionable details survive; absent, blank, screened, and unselected details retain the readable fallback without exposing raw payloads. Identity and refusal controls remain intact. The shared prerequisite and presentation consumer are separate commits. Reused recorded successful evidence: seven released-runtime refusal cases, four mounted presentation cases, and seven recovery cases; the dependent receipts identify this exact revision. No new tests or CI checks were needed. All inspection processes completed, and the checkout remains unchanged.

Non-blocking observations

  • Minimalism and adjacent error presentation: packages/cli/src/repl/sidekick/owner.ts:2864 prefers attempted.error for every failed reply, although classified resume failures already reconstruct their screened diagnostic from the saved record in packages/agent/src/journal.ts:686 and conversation.ts:1246,1265. The additional turnForRequest error field is therefore unnecessary for the accepted resume behavior. This preference can also hide the more specific live identity refusal from conversation.ts:1227 when the associated failed record has its own error. The operation still refuses and preserves identity, so this does not block the reviewed acceptance clauses. A smaller implementation would format replied.error with readPromptDiagnostic and remove the added saved-error field.

  • Bounding interpretation: packages/cli/src/repl/sidekick/model.ts:865 displays the selected details string in full. The original scope requests reuse of existing bounded structured facts; specs/acp-client-spec.md:1179 defines that selection as protocol code, message, and data.details without a character limit. Accordingly, no new length limit is required for acceptance. Rendering cost can grow with detail length, but this review found no measured performance regression and did not impose a new truncation contract.

This PR targets the prerequisite branch. The repository CI workflow selects PRs targeting main. Its mounted presentation and recovery checks passed locally at this exact head. The required CI run will follow retargeting after the prerequisite merges.

@taras
taras force-pushed the codex/resume-diagnostics-1388 branch from 907b60c to f3d09c7 Compare November 17, 2026 18:08

taras commented Nov 17, 2026

Copy link
Copy Markdown
Owner Author

Restacked on corrected prerequisite #1391 at 4c32dd3482fe08fbdb8f1515397b2c0761ff923f. New head: f3d09c7c1a11c08f07fd178236a0dd5d4e4baa73.

The presentation patch retains its previously reviewed behavior. Its only patch change is removing the issue-number prefix from the added test title, following the review feedback. The inherited prerequisite now owns early-resume mapping entirely in XMD and adds no vendored ACPX changes.

Independent review: PASS on this exact head, Codex Astra gpt-6-astra, under the documented Fable quota fallback. The reviewer compared the old and new presentation patches and checked compatibility with the new mapping. No integration defect found. Previous nonblocking observations about saved-error preference and unspecified detail length remain unchanged.

The mounted presentation/recovery selection passes all eleven steps, including actionable, absent, blank and screened detail while live and after passive reopen. The prerequisite's Deno, Node, Bun, vendor and clean-checkout verification passed. This PR remains draft with its stacked base unchanged.

@taras
taras added this pull request to stack #1394 November 17, 2026 19:52
Base automatically changed from codex/resume-diagnostics-retention-1388 to main November 17, 2026 19:53
@taras
taras force-pushed the codex/resume-diagnostics-1388 branch from f3d09c7 to aa12dc0 Compare November 17, 2026 19:53
@taras
taras marked this pull request as ready for review November 17, 2026 21:28
@taras
taras merged commit 730e6d5 into main Nov 17, 2026
62 of 64 checks passed
@taras
taras deleted the codex/resume-diagnostics-1388 branch November 17, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show the cause of failed Sidekick session resumes

1 participant