Repository navigation
Wait for History Close focus before measuring wheel positions - #1406
Conversation
The held-answer History case pressed Tab and then captured the Entry 1 row. Focus guidance above the History window wraps to a different number of rows for a focused list row than for Close, so a capture that read the frame before Tab's repaint measured a row one below where the window settles. The reverse wheel then waited at that stale row and timed out. Wait for the Close guidance before capturing, so the marker comes from the geometry the wheel actually scrolls. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Independent Fable review: PASS on signed The reviewer reconstructed the saved terminal/journal sequence: Tab changes focused-row guidance to Close guidance, reducing it from four lines to three. The old marker is captured one row too low. The first wheel and reverse move correctly; the stale equality then fails. The added The controlled stale-capture witness fails on clean Nonblocking observations retained by Fable: actual runner joins establish completion (a literal Reviewer: native Claude Required PR CI and post-merge macOS/Ubuntu host checks remain separate gates. Keep #1405 open until the repaired main run succeeds; #1399 is automatic. |
|
Delivery checks passed on exact reviewed head Original Planner and independent native Fable reviews are PASS. Marking ready for maintainer merge. After merge, the authoritative main run must still verify the hosted macOS and Linux REPL bench jobs. Dedicated flake #1405 stays open until that causal repair evidence is green; automatic health issue #1399 is left to its own main-health workflow. |
|
Post-merge verification at main The run's remaining non-bench checks are still active, with no failures at this checkpoint. Main health has not yet been declared green; #1399 remains under its automatic workflow. |
Why
Main's macOS bench failed the scripted Sidekick History case while the other 41 cases passed. Tab changes the drawer's focus to Close, whose shorter guidance moves the reading up one row. The test could measure coordinates before that repaint, then reject a correct reverse scroll using the stale row.
Refs #1399 and #1405. The automatic main-health issue and dedicated flake remain open until their delivery conditions are met.
What changes
Before: the History test captured its marker immediately after Tab.
After: it waits for
Enter closesinside the History region, then captures the marker. The wheel movements, coordinate equalities, held Sidekick answer and final outcome checks stay intact.How to verify it
b2bc6f1c; acknowledging Close before measuring passes.cc655e75736e6fb7774b80bf004708ff790137a7.Scope
One added wait in one Markdown test. It acknowledges the action's visible result; it adds no sleep, warm-up tick, deadline increase or product change.
Risks and limitations
Required PR CI does not run the main-only host journeys. The maintainer's merge supplies the next macOS and Ubuntu hosted confirmation; both must be checked before declaring main healthy.
Scope confirmation