Skip to content

Wait for History Close focus before measuring wheel positions - #1406

Merged
taras merged 1 commit into
mainfrom
codex/main-history-wheel-repair
Nov 18, 2026
Merged

taras merged 1 commit into
mainfrom
codex/main-history-wheel-repair

Conversation

@taras

@taras taras commented Nov 18, 2026

Copy link
Copy Markdown
Owner

Why

Main's macOS bench failed the scripted Sidekick History case while the other 41 cases passed. Tab changes the drawer's focus to Close, whose shorter guidance moves the reading up one row. The test could measure coordinates before that repaint, then reject a correct reverse scroll using the stale row.

Refs #1399 and #1405. The automatic main-health issue and dedicated flake remain open until their delivery conditions are met.

What changes

Before: the History test captured its marker immediately after Tab.

After: it waits for Enter closes inside the History region, then captures the marker. The wheel movements, coordinate equalities, held Sidekick answer and final outcome checks stay intact.

How to verify it

  • The unchanged main document passed all four cases locally, demonstrating the timing-sensitive source contrast. Local Deno was 2.9.7 versus CI's 2.9.5, with pinned Bun 1.4.0.
  • A controlled old-coordinate witness fails at the same row/column predicate on clean b2bc6f1c; acknowledging Close before measuring passes.
  • The candidate's complete four-case journey and wide/narrow UI preflight passed. Tested patch and committed patch hashes match.
  • Original Planner and independent Fable: PASS on signed cc655e75736e6fb7774b80bf004708ff790137a7.

Scope

One added wait in one Markdown test. It acknowledges the action's visible result; it adds no sleep, warm-up tick, deadline increase or product change.

Risks and limitations

Required PR CI does not run the main-only host journeys. The maintainer's merge supplies the next macOS and Ubuntu hosted confirmation; both must be checked before declaring main healthy.

Scope confirmation

  • Every changed line supports the History timing repair.
  • Existing wheel, focus and outcome checks are preserved.
  • No generated source or unrelated cleanup is included.
  • The description matches the final diff and verification.

The held-answer History case pressed Tab and then captured the Entry 1
row. Focus guidance above the History window wraps to a different number
of rows for a focused list row than for Close, so a capture that read the
frame before Tab's repaint measured a row one below where the window
settles. The reverse wheel then waited at that stale row and timed out.

Wait for the Close guidance before capturing, so the marker comes from
the geometry the wheel actually scrolls.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@taras taras added the ci-main-red-fix Maintainer-controlled: lands one PR while main is red, only with the full clean-checkout proof label Nov 18, 2026 — with ChatGPT Codex Connector

taras commented Nov 18, 2026

Copy link
Copy Markdown
Owner Author

Independent Fable review: PASS on signed cc655e75736e6fb7774b80bf004708ff790137a7, all three acceptance clauses covered, no blocking findings.

The reviewer reconstructed the saved terminal/journal sequence: Tab changes focused-row guidance to Close guidance, reducing it from four lines to three. The old marker is captured one row too low. The first wheel and reverse move correctly; the stale equality then fails. The added Enter closes acknowledgement occurs before marker capture inside the existing History region and matches actual Close focus.

The controlled stale-capture witness fails on clean b2bc6f1c; its acknowledged counterpart passes. All four candidate cases and the wide/narrow preflight pass. Original wheel amounts, exact equalities, held Sidekick answer and final outcome remain unchanged. Original Planner also returned PASS; the ordinary workflow generated the delivery feedback record.

Nonblocking observations retained by Fable: actual runner joins establish completion (a literal joined: true alone would not); terminal frames may be observed between callbacks; and the recorded History frame raises a preexisting question about Close guidance without a visible close cell. None requires a change to this bounded timing repair.

Reviewer: native Claude claude-fable-5-2, session main-history-wheel-independent-20261117; provider and outer command joined successfully. Receipt SHA-256: 1f3d9bbc80097a5ce135357eb87d352a6164274a5bb4b38da7b515300e2b94cd.

Required PR CI and post-merge macOS/Ubuntu host checks remain separate gates. Keep #1405 open until the repaired main run succeeds; #1399 is automatic.

taras commented Nov 18, 2026

Copy link
Copy Markdown
Owner Author

Delivery checks passed on exact reviewed head cc655e75736e6fb7774b80bf004708ff790137a7: CI run 44226044035 completed successfully, including all Deno, Node and Bun shards, main-green, composability and the green aggregate.

Original Planner and independent native Fable reviews are PASS. Marking ready for maintainer merge. After merge, the authoritative main run must still verify the hosted macOS and Linux REPL bench jobs. Dedicated flake #1405 stays open until that causal repair evidence is green; automatic health issue #1399 is left to its own main-health workflow.

@taras
taras marked this pull request as ready for review November 18, 2026 03:12
@taras
taras merged commit 1ce93ad into main Nov 18, 2026
72 of 127 checks passed
@taras
taras deleted the codex/main-history-wheel-repair branch November 18, 2026 03:13

taras commented Nov 18, 2026

Copy link
Copy Markdown
Owner Author

Post-merge verification at main 1ce93ad5ee0b7420f9218f22f2ff30280cecc01e: both hosted REPL bench jobs passed in run 44228908083.

  • macOS: 42 passed, 0 failed.
  • Ubuntu: job passed; original full log preserved.

The run's remaining non-bench checks are still active, with no failures at this checkpoint. Main health has not yet been declared green; #1399 remains under its automatic workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-main-red-fix Maintainer-controlled: lands one PR while main is red, only with the full clean-checkout proof

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant