Introduce ContextDimension#293
Merged
Merged
Conversation
5 tasks
|
blocked by #294 |
Contributor
|
This does not look good: |
thrix
reviewed
Apr 30, 2026
thrix
reviewed
Apr 30, 2026
1 task
Contributor
|
LGTM, in general the operator-based approach fits my view how these things should be implemented. I guess I will have a comment or two, mostly minor ones, when I get back in the evening. |
happz
reviewed
May 18, 2026
4dba56d to
3204c6c
Compare
Signed-off-by: Cristian Le <git@lecris.dev>
tcornell-bus
approved these changes
May 21, 2026
thrix
reviewed
May 22, 2026
psss
approved these changes
May 26, 2026
Member
psss
left a comment
There was a problem hiding this comment.
Looks good. Just the missing release note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is quite a big one, but I will keep the commits relatively logically contained for easier review commit by commit. The idea here is:
ContextDimensionContextDimensionby sub-classing it and defining the_dimension_nameit is linked tocreate_defaultis used, which by default wraps aroundContextValuefor backwards-compatibilityContextDimensioninstead.Operatorsand decorators were added to manage these more dynamicallystaticmethod->classmethodto allow expanding theContextclassre_expression_triplewas made a function for the reason aboveCloses #289
Depends-on #297
Checklist