Sync typing and warnings compat from tmt#297
Merged
Merged
Conversation
LecrisUT
requested review from
happz,
janhavlin,
lukaszachy,
psss and
thrix
as code owners
LecrisUT
force-pushed
the
feat/typing-compat
branch
from
28bb67e to
2e00248
Compare
Member
|
This is blocking #293, adding to the sprint. |
Contributor
|
"Sync typing compat from tmt" - and warnings too, right? |
Member
Author
Technically still typing related (from |
psss
approved these changes
May 19, 2026
psss
changed the title
typing and warnings compat from tmt
Member
Ok, title updated and approved. One more review missing. |
therazix
approved these changes
May 19, 2026
therazix
pushed a commit
that referenced
this pull request
Jun 2, 2026
This is quite a big one, but I will keep the commits relatively logically contained for easier review commit by commit. The idea here is: - Add a container for defining the context dimension comparison operators: `ContextDimension` - Users can extend `ContextDimension` by sub-classing it and defining the `_dimension_name` it is linked to - If a dimension is not found in the sub-classes, the `create_default` is used, which by default wraps around `ContextValue` for backwards-compatibility - All of the comparator logic was moved to `ContextDimension` instead. `Operators` and decorators were added to manage these more dynamically - Some cleanups - `staticmethod` -> `classmethod` to allow expanding the `Context` class - `re_expression_triple` was made a function for the reason above - Dropped some dead-code parts Closes #289 Depends-on #297 --------- Signed-off-by: Cristian Le <git@lecris.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ruff rules are not synced because ruff is not configured here