Repository navigation
Conversation
Signed-off-by: Tee8z <tee8z@protonmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
Signed-off-by: Tee8z <tee8z@protonmail.com>
|
Independent agent review of One remaining build blocker: include the generated The MCP content migration preserves text/image byte budgets and explicit elision. Its fallback handles future non-exhaustive content variants without leaking raw content. The metadata regression fixture stays below rmcp's 16-MiB frame ceiling so it continues testing Buzz's own count/metadata guards rather than an SDK rejection. The maintainer explicitly authorized the temporary SQLite advisory exception in the active root conversation: Validation evidence supplied by the implementing agent: 805 MCP tests pass, Clippy passes, and all cargo-deny gates pass. I reviewed that code and the matching fixtures; I did not rerun the suite while storage was constrained. Full Scores: minimalism 9/10, elegance 9/10, correctness 8/10 until the separate desktop lock update is committed. No other concrete blockers found in this scope. Human workflow testing is not attested. |
Signed-off-by: Tee8z <tee8z@protonmail.com>
|
Resolved my review blocker: desktop Cargo.lock now includes the rmcp 3.9 update in ea6e9b4. The human explicitly accepted the unchanged upstream SQLite advisory; 18b0395 scopes the corresponding exceptions across the separate runtime, mesh and desktop policy checks. No remaining blockers from my initial review. Human workflow testing remains pending. |
Problem and behavior
The checkpoint PR's security gate flags unbounded MCP HTTP buffering, an unbounded server schema cache, and OAuth metadata SSRF in the locked MCP SDK versions. Update both native client and server consumers to
rmcp 3.9.0and unify the lockfile on that patched release.Adapt the agent's tool-result conversion to the new
ContentBlockAPI. Existing text and image byte budgets remain intact. The metadata regression fixture stays below the SDK's new 16 MiB stdio frame limit so it still reaches Buzz's tool-count guard.Record the maintainer-approved temporary exception for
RUSTSEC-2026-0459: the dev-only Mesh dependency cannot yet select the patched SQLite stack. Remove that exception when the upstream parent supports it.Validation
cargo check -p buzz-agent -p buzz-dev-mcp -p sprig --all-targetspassed.cargo test -p buzz-agent -p buzz-dev-mcp -p sprig -- --test-threads=2: 805 passed, including real agent/MCP subprocess journeys.--all-targets -- -D warnings, formatting, and diff checks passed.cargo deny check: advisories, bans, licenses, and sources passed with the scoped SQLite exception.just cipassed workspace Rust clippy after bypassing a localsccacheoversized-archive failure, then failed in desktop Tauri clippy becauseglib-2.0.pcis unavailable. The complete repository gate is not green locally.Draft pending independent review and human confirmation. No relay, cluster, or production changes were performed.
The desktop lock synchronization is published in ea6e9b4; independent review confirms that blocker is resolved.
The maintainer-approved SQLite exception now also appears in
deny-mesh.tomland
deny-desktop.toml, matching the separate CI graphs (18b0395).Runtime, mesh-smoke, and desktop dependency policy checks all pass, as does the
existing desktop exception guard. The exception remains limited to the known
upstream advisory and must be removed after a compatible mesh dependency upgrade.
Hosted checks also exposed unrelated runner/flake selection failures: Playwright
runner compatibility is prepared in #162; platform-only Rust flake selection
is being fixed separately. These failures are not MCP test failures.