Repository navigation
Conversation
Signed-off-by: Tee8z <tee8z@protonmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
|
Independent review of 9c0bdb0: no blocking or optional findings. The diff pins precisely the three jobs that install and run Playwright to I independently ran actionlint for all three changed workflows, the CI required-gate and apt-retry test suites (37 passed), and the diff check. I inspected each affected job in context; I did not execute a hosted Playwright job myself. Scores: minimalism 9/10, elegance 9/10, correctness 9/10. Hosted workflow verification and the repository's human confirmation requirement still govern readiness; this is not a |
The pinned Playwright cannot install Chromium on the Ubuntu 26.04 image now selected by
ubuntu-latest. Desktop smoke and relay integration fail before reaching app tests, including on #149 and #155.Pin the three browser jobs (smoke, relay integration, and flake smoke) to supported Ubuntu 24.04. Rust and other non-browser jobs keep their existing runners. Browser versions, test selection, timeouts, and gates remain the same.
Validation: actionlint passes for all three workflows; all 29 required-gate tests and the existing apt-retry tests pass. The exact failed CI logs show
Playwright does not support chromium on ubuntu26.04-x64. A real hosted rerun remains necessary to confirm browser installation; this machine cannot emulate a GitHub hosted runner.Draft pending independent review and human confirmation of the hosted checks. No deployment or review-completed attestation.