Repository navigation
fix: reject primitive RPC responses without retrying - #2
Draft
1932819331hy-debug wants to merge 1 commit into
Draft
1932819331hy-debug wants to merge 1 commit into
1932819331hy-debug wants to merge 1 commit into
Conversation
Signed-off-by: 1932819331hy-debug <343001481+1932819331hy-debug@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an object-type guard before checking for
result, restoring the existing unreadable-response contract. Valid results, including null, explicit RPC errors and transient transport retries keep their behavior. Onlysrc/rpc.jsand a focused regression file change.Evidence
13184ff111532c172f37d54d59f00e7eea6b9a23.After: all 17 pass; native
npm testpasses 40/40.This is a source-backed contract repair, not completion of a separate maintainer issue. AI assistance was used for implementation, testing and review.
Merge Danger
Door: Two-way. One production guard, with no migration.
Blast Radius: RPC.
Malformed truthy primitive responses now stop immediately rather than being retried. JSON parse-error and broader retry policies are unchanged.