Skip to content

(1/9) Use the sync package for all desktop GitHub access - #85

Draft
AntonNiklasson wants to merge 1 commit into
an/gui-shared-syncfrom
an/feedback-loops/1/sync-only
Draft

AntonNiklasson wants to merge 1 commit into
an/gui-shared-syncfrom
an/feedback-loops/1/sync-only

Conversation

@AntonNiklasson

@AntonNiklasson AntonNiklasson commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Summary

The GUI still had its own GitHub clients and live JSON cache alongside the shared engine. Remove those paths, delegate comments and diffs to sync, and remove actions/views the engine does not support yet.

Validation

Local stack head 1d1d925 passed:

  • pnpm typecheck, pnpm test (171 unit/integration tests)
  • pnpm lint (including four boundary checks), pnpm fmt:check
  • pnpm test:e2e (five Chromium scenarios)
  • pnpm test:desktop (packaged macOS arm64 launch, restart, SQLite and shutdown)

These are local results; GitHub checks are reported separately.

How to review

Start with server/routes.ts and web/api.ts. Most removed lines are the legacy fetchers, routes and their tests. Unsupported endpoints now return 404; the menus and shortcuts no longer expose them.

Visuals

Menus and engine-backed comments/diffs were exercised locally. Later stack layers provide repeatable screenshots.

Related

Part of #84. Prerequisite: #83.

This PR is part of a stack; review and merge from the bottom upward. Each PR targets the preceding branch.

  1. #85: Use the sync package for all desktop GitHub access ← This PR
  2. #86: Add a deterministic GitHub simulator
  3. #87: Run an isolated interactive status board
  4. #88: Verify renderer polling through the real sync engine
  5. #89: Show persisted sync health and stale-data warnings
  6. #90: Exercise conflict, review, rate-limit and partial-outage states
  7. #91: Guard clients against bypassing the public sync API
  8. #92: Attach named visual states to browser reports
  9. #93: Launch and restart the packaged Electron app in isolation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant