Repository navigation
(6/9) Exercise conflict, review, rate-limit and partial-outage states - #90
Draft
AntonNiklasson wants to merge 1 commit into
Draft
AntonNiklasson wants to merge 1 commit into
AntonNiklasson wants to merge 1 commit into
Conversation
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expand the simulator and real-engine/browser checks for conflicts, approval changes, empty lists, rate-limit reset, review membership and one failing host among two. Keep assignment-only fixtures separate from review requests; the product inbox query remains unchanged. Scope React row keys to each instance to avoid collisions across hosts.
Validation
Local stack head
1d1d925passed:pnpm typecheck,pnpm test(171 unit/integration tests)pnpm lint(including four boundary checks),pnpm fmt:checkpnpm test:e2e(five Chromium scenarios)pnpm test:desktop(packaged macOS arm64 launch, restart, SQLite and shutdown)These are local results; GitHub checks are reported separately.
How to review
Read states.e2e.ts and github.test.ts as acceptance scenarios, then github.ts. Runtime controls refresh all list kinds so recovery is deterministic.
Visuals
Named scenario screenshots are attached by layer 8.
Related
Part of #84. Prerequisite: #83.
This PR is part of a stack; review and merge from the bottom upward. Each PR targets the preceding branch.