Repository navigation
(9/9) Launch and restart the packaged Electron app in isolation - #93
Draft
AntonNiklasson wants to merge 1 commit into
Draft
AntonNiklasson wants to merge 1 commit into
AntonNiklasson wants to merge 1 commit into
Conversation
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add pnpm test:desktop and run it in macOS CI. Launch the actual unsigned directory package twice, verify app.isPackaged and its shipped SQLite addon, read persisted data across restart, and confirm both embedded servers close on quit. Isolate Electron profile/config/cache, disable update downloads for the test, and restore/probe the host Node addon after packaging even on failure.
Validation
Local stack head
1d1d925passed:pnpm typecheck,pnpm test(171 unit/integration tests)pnpm lint(including four boundary checks),pnpm fmt:checkpnpm test:e2e(five Chromium scenarios)pnpm test:desktop(packaged macOS arm64 launch, restart, SQLite and shutdown)These are local results; GitHub checks are reported separately.
How to review
Read harness/src/app.desktop.ts, then scripts/desktop-smoke.mjs. The desktop main-process changes only provide profile isolation and an update opt-out. Verified locally on macOS arm64; signing, installer/updater delivery and other platform launches are not covered.
Visuals
First-launch and restart PNGs plus packaged-process diagnostics are attached to desktop-report and the packaged-desktop-feedback CI artifact.
Related
Part of #84. Prerequisite: #83.
This PR is part of a stack; review and merge from the bottom upward. Each PR targets the preceding branch.