Repository navigation
Conversation
The viewer drew a band across the top just to hold the modal's close button, and moved between images with chevrons. Now the image sits on black that reaches the edges, with the app's round sheet buttons floating over it: close on the left, save on the right. Swiping sideways pages through a commit's images, with dashes at the bottom that slide to the current one. At its whole size an image can be dragged up or down: it follows the finger, the black fades, and letting go far enough (or flicking) closes the viewer. A short drag springs back. Once zoomed, a drag pans instead, until a pinch brings the image back to its whole size. Save puts the image in the phone's photo library through a small local plugin (packages/photos), since no NativePHP plugin does this. iOS asks for add-only photo access with a new usage string. Android 10 and up needs no permission. A toast says how it went. The viewer's state moved out of ShowsCommits into its own ShowsImageViewer trait, so other screens (Remotes next) can use it. Android keeps the modal's own close row for now: mobile-ui's modal only closes on Android's back while it's dismissible, and dismissible draws the row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks the full-screen image viewer.
sheet-bar-button, same as the composer's cross) float over it: close on the left, save on the right.packages/photos, likepackages/calls. iOS asks for add-only access with a newNSPhotoLibraryAddUsageDescription. Android 10+ needs no permission and saves to Pictures/devnull. It uses the copy in the image cache, or downloads the image first.ShowsCommitsinto a newShowsImageViewertrait. Any screen can use it by callingshowImagesInViewer($images, $index)and including the partial once. Remotes is next.Things to know:
@pinchEnd). A side effect: the first pinch on an image zooms around its middle, later ones around the fingers.dismissibleis on, anddismissibleis what draws the row. Turning it off made back do nothing. A modal option to hide the row but keep back would fix this.Tested on an iOS 27.0 simulator and an Android 35 emulator against a local API with real photo commits: paging both ways, short and long drags, save (it landed in the simulator's Photos and the emulator's Pictures/devnull, toast shown over the viewer). Pinch, pan while zoomed and pinch back were checked on Android with injected two-finger touches. The iOS simulator tools here can't pinch, so on iOS I opened an image already zoomed to check that a drag pans it and doesn't page or close.
php artisan test: 1906 passed.Screenshots
Recordings: iOS light, paging then drag to close, Android dark, paging, pinch, pan and drag to close
🤖 Generated with Claude Code