Skip to content

docs(menu-separator): phase 7 documentation - #6891

Closed
blunteshwar wants to merge 8 commits into
menu-separator-migrationfrom
menu-separator-phase-7-docs
Closed

blunteshwar wants to merge 8 commits into
menu-separator-migrationfrom
menu-separator-phase-7-docs

Conversation

@blunteshwar

Copy link
Copy Markdown
Contributor

Description

Phase 7 (documentation) of the swc-menu-separator migration. Stacked on #6890 (Phase 6) and targets the menu-separator-migration feature branch, so the diff includes earlier phases until they merge.

  • menu-separator.mdx: Anatomy, Options, Behaviors (placement), and Accessibility sections.
  • migration-guide.mdx: sp-menu-divider to swc-menu-separator (rename, size removed, --mod-* removed, placement).
  • Adds the Accessibility story that the MDX page embeds.
  • Adds the gen2 changeset menu-separator-gen2-migration.md (minor for @adobe/spectrum-wc and @adobe/spectrum-wc-core).
  • Ticks the JSDoc and migration guide items in the plan.

Not covered yet

  • The story with a separator between labelled swc-menu-group blocks: swc-menu-group is not migrated yet.
  • Placement rules in the guide are limited to guidance; the dev-mode placement warning (A1, Q7) is still open.

Validation

  • yarn workspace @spectrum-web-components/gen2 build: passed
  • npx eslint and npx prettier --check on the component and changeset: passed
  • Storybook was not run locally, so the MDX pages were not rendered.

@changeset-bot

changeset-bot Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6b6e301

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@blunteshwar

Copy link
Copy Markdown
Contributor Author

Issues: (1) The migration guide says the 1st-gen role is "overridable". It isn't: MenuDivider.firstUpdated sets role="separator" unconditionally. Drop the Role row from the "Changed" table, or change it to say the role is fixed in both. (2) The docs page says arrow-key navigation "moves past" the separator. That depends on swc-menu roving focus with swc-menu-item, which isn't verified yet. Soften it to say the separator isn't focusable. (3) The Accessibility story is identical to Anatomy, so it adds no coverage. Either show it inside a role="menu" container or reuse one story. (4) The changeset says Playwright accessibility tests were added, but they haven't been run yet.

@blunteshwar
blunteshwar force-pushed the menu-separator-phase-7-docs branch from 7424c77 to 6b6e301 Compare November 2, 2026 04:42
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

📚 Branch Preview Links

🔍 Gen1 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-6891

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@blunteshwar

Copy link
Copy Markdown
Contributor Author

Combined into #6893.

@blunteshwar blunteshwar closed this Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant