Skip to content

test(gates): keep package-boundaries.test.ts under max-lines - #4630

Open
thymikee wants to merge 1 commit into
mainfrom
fix/layering-test-max-lines
Open

thymikee wants to merge 1 commit into
mainfrom
fix/layering-test-max-lines

Conversation

@thymikee

@thymikee thymikee commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Summary

Main's CI fails at fce2fa6247 on oxlint: scripts/layering/package-boundaries.test.ts:1001:4: File has too many lines (1001). #4604 added one R11 export entry (@agent-device/capture-kit/capture-fact-grace) while main had already grown the file to exactly 1000 lines, so each change passed on its own and the merge broke the cap.

This removes one comment that repeated the in-memory fixture note a few tests above (// These src/utils paths are in-memory arbitrary parser fixtures…). No gate reads that comment; the retired-paths policy checks tracked files, not string literals. The file is back to 1000 lines.

Validation

  • wc -l reports 1000; max-lines in oxlint.config.ts counts comment lines (no skipComments).
  • CI runs oxlint and the layering tests.

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

View guided diff Turn on auto-fix

…test.ts under max-lines

#4604 added one R11 export entry to a file that main had already grown to
1000 lines, so main's oxlint max-lines check fails at 1001. The removed
comment repeated the in-memory fixture note a few tests above.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 6.35 MB 6.35 MB +18 B
Package (unpacked) 6.35 MB 6.35 MB +18 B
Package (download) 1.93 MB 1.93 MB +7 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 21.8 ms 20.8 ms -1.0 ms
CLI --help 46.7 ms 47.2 ms +0.5 ms

@apex-sentinel-staging

Copy link
Copy Markdown

Apex Sentinel · ✅ Approve

No open findings.

1 finding below minor hidden (user_settings.min_severity).

Reviewed with this repository's own Sentinel configuration (fce2fa6247c5).

💬 Talking to Sentinel

In a finding's thread, reply with:

Command What it does
@apex-sentinel-staging note <context> Adds context; Sentinel re-checks the cited code
@apex-sentinel-staging pivot <why> Says the finding is wrong; Sentinel re-checks the cited code
@apex-sentinel-staging like Marks the finding as useful
@apex-sentinel-staging dislike <why> Marks it as not useful, so it is not raised again

On this conversation, comment @apex-sentinel-staging review to run a full review once again.

@thymikee

Copy link
Copy Markdown
Member Author

This PR is ready at 23c89e1. The change only deletes a comment in a test file, so it cannot affect any runtime route, and all 20 checks pass. Not blocking, and you can take or leave it: the file now sits exactly at the 1000-line cap, so the next added line will break lint again, and splitting it by test group when next touched would fix that (the deleted comment at scripts/layering/package-boundaries.test.ts:275 explained the in-memory fixture for the src/utils literal).

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Nov 17, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant