Repository navigation
acc: quote cluster policy ids substituted into databricks.yml - #7793
Merged
Merged
Conversation
Cluster policy ids are 16 hex characters. Substituted unquoted into YAML, an id made of digits with a leading zero parses as an integer (0012345678901234 -> 12345678901234) and digits around a single E parse as a float (12345678901E0042 -> 1.2345678901e52), so jobs/create gets an invalid policy id. cloud: TestAccept/bundle/config-remote-sync/external_cluster_policy_cross_target Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/acc-quote-cluster-policy-ids
branch
from
November 19, 2026 09:53
5dfeb24 to
0d9c950
Compare
Contributor
|
Commit: Regression test reportSelected 3 changed tests (limit=20, 0 not selected) 6 tests: regression=0 unreleased=0 coverage=6 failing=0
|
Collaborator
✅ Integration test reportCommit: 0d9c950
Top 3 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Nov 19, 2026
This was referenced Nov 19, 2026
Collaborator
❌ Integration test reportCommit: 9579aef
1345 interesting tests: 1332 MISS, 5 PANIC, 4 KNOWN, 4 FAIL
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Quote the cluster policy ids that the config-remote-sync tests substitute into
databricks.yml. The fix is inexternal_cluster_policy_cross_targetand also in the local-onlycluster_policy_replaces_arrayandmissing_cluster_policytests.Why
Cluster policy ids are 16 hex characters. Substituted unquoted, YAML sometimes reads them as numbers:
0012345678901234→12345678901234Ebecome a float:12345678901E0042→12345678901000…000(53 digits)jobs/createthen rejects the mangled id. Both forms seen in CI reproduce locally withbundle validate, and quoting fixes both. This is standard YAML behavior, not a CLI bug, so only the test templates change.Tests
external_cluster_policy_cross_targeton AWS: pass.cloud:), so the PR's cloud run executes it.Dashboard
Error: cannot create resources.jobs.policy_sync: '[ID]' is not a valid cluster policy ID. (400 INVALID_PARAMETER_VALUE)'[ID]' (a 77-digit number) is not a valid cluster policy ID.This pull request and its description were written by Isaac.