Skip to content

ci: prepare ESA SDK maintenance release lane - #3734

Open
rachitm022 wants to merge 1 commit into
mainfrom
rmatani/ai-22389-receive-esa-package-revisions-through-core
Open

rachitm022 wants to merge 1 commit into
mainfrom
rmatani/ai-22389-receive-esa-package-revisions-through-core

Conversation

@rachitm022

Copy link
Copy Markdown
Collaborator

Why

The ESA Core reporting E2E needs SDK package coverage while existing buyers remain pinned to AdCP 3.3.0-beta.5 and the staging ESA serves 3.3.0-beta.6. The current SDK 17 beta channel has moved to rc.0. A maintenance prerelease from SDK beta.22 lets us ship the exact reporting compatibility without changing the default SDK 17 beta or SDK 16 stable releases.

What changed

  • Allow CI, Changesets, reference-seller interop and CodeQL to run for 17.x-esa.
  • Let the release workflow publish that branch under the separate adcp-3.3-esa npm dist-tag. Other branches keep their existing tags.
  • Document the maintenance branch and its exact protocol versions.

This PR only prepares the release lane. The package backport will be reviewed separately against 17.x-esa; no SDK package version or protocol bundle changes here.

Tracks AI-22389.

Checks

  • npm run lint:workflows
  • npm run ci:doc-links
  • npm run format:check
  • git diff --check

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — clean infra/CI PR.

This PR adds 17.x-esa maintenance-branch support across CI/release workflows plus two consistent doc updates (7 files, +16/-9). No source code under src/lib/**, bin/**, or build-affecting scripts/** is touched, so witness-not-translator, version-pathway, official-transport, and changeset-vs-wire-impact gates do not apply. The one load-bearing change — the ADCP_NPM_TAG ternary in release.yml — was verified against publish-adcp-release.ts: '' on main/16.x is falsy and falls through to the existing pre-mode/latest tag (no regression), while adcp-3.3-esa on the maintenance branch takes precedence correctly. Concurrency serialization, the changeset-check regex extension, and the exempt-path/no-changeset posture are all correct.

Gate checks:

  • No no-auto-approve team match.
  • gated_paths: false (row 2 does not apply despite review_decision=REVIEW_REQUIRED).
  • high_risk: false; no deletions in sensitive paths.
  • No critical/high/medium findings.

Rows 1–8 do not fire; falls through to row 9 → approve.

@rachitm022

Copy link
Copy Markdown
Collaborator Author

Closing while we verify the complete staging reporting path. The local SDK backport and host compatibility checks can continue independently; we can reopen this release lane if those checks establish it is needed.

@rachitm022 rachitm022 closed this Nov 17, 2026
@rachitm022 rachitm022 reopened this Nov 17, 2026
@rachitm022
rachitm022 force-pushed the rmatani/ai-22389-receive-esa-package-revisions-through-core branch from d052b08 to 32fa4b3 Compare November 17, 2026 14:29

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — infrastructure-only PR adding the 17.x-esa maintenance branch to five CI/release workflows plus CLAUDE.md and NPM-DIST-TAGS.md docs.

No blocking findings. Reviewer verified the ADCP_NPM_TAG expression (github.ref_name == '17.x-esa' && 'adcp-3.3-esa' || '') resolves to an empty string on main/16.x — falsy in resolvePublishTag (publish-adcp-release.ts:57), preserving existing beta/latest channels — while 17.x-esa correctly overrides to the adcp-3.3-esa dist-tag. No src/lib/bin/published-file changes, so no changeset required. Docs claims are consistent.

Decision table: no critical/high/medium findings (rows 1, 4–6, 8 don't fire); gated_paths false and review_decision APPROVED (row 2 n/a); high_risk false (rows 3, 5 n/a); no no-auto-approve team match (row 7 n/a); prior decision was approve (row 6 n/a). Falls through to row 9 → approve.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant