starknet_os: os resources test - measure linear factor, add deploy

[dorimedini-starkware]

No description provided.

[dorimedini-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• starknet_os: os resources test - add send_message_to_l1 #14143 : 2 dependent PRs (#14144 , #14153 )
• starknet_os: os resources test - add replace_class #14142
• starknet_os: os resources test - support virtual builtins, add sha256 #14141
• starknet_os: define sha256 batch resources constants #14140
• starknet_os: os resources test - add keccak #14139
• starknet_os: os resources test - add 3 more syscalls #14138
• starknet_os: os resources test - remove all fee transfer syscalls #14137
• starknet_os: os resources test - add emit event #14136
• starknet_os: os resources test - add meta tx #14135
• starknet_os: os resources test - measure linear factor, add deploy #14134 👈 (View in Graphite)
• starknet_os: os resources test - library call #14129
• starknet_os: initial test, measure call contract resources #14128
• blockifier_test_utils: add option to deploy from zero in test accounts #14258
• starknet_os_flow_tests: helper function to declare explicit classes #14257
• starknet_os: os resources test - create fixed deployable account #14173
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[cursor]

PR Summary

Medium Risk
Changes fee/resource accounting constants and the OS program hash used for proving; incorrect values would mischarge Deploy or break OS hash checks.

Overview
Extends the OS resources regression test so syscall costs can be recorded as either flat ExecutionResources or VariableResourceParams with constant + calldata linear factor, by pairing back-to-back traces for Deploy and MetaTxV0.

The Cairo1 measurement contract now invokes deploy_syscall twice (base vs longer calldata), with stable salt/deploy_from_zero to keep address normalization from skewing results; Deploy is removed from the unmeasurable syscall list.

Measured Deploy overhead is written into 0.14.4 versioned constants (higher constant steps/Pedersen), DEPLOY_GAS_COST in OS Cairo constants, the OS program hash, and the 0.14.3→0.14.4 constants diff regression snippet.

^{Reviewed by Cursor Bugbot for commit cca3d02. Bugbot is set up for automated code reviews on this repo. Configure here.}

[Yoni-Starkware]

@Yoni-Starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).

---

crates/blockifier/resources/blockifier_versioned_constants_0_14_3.json line 253 at r3 (raw file):

                    "builtin_instance_counter": {
                        "range_check_builtin": 21,
                        "pedersen_builtin": 8

Should be 7. It's 8 here because your base case is with array![0]...
Maybe do 3 calls? base, linear[1], linear[2]?

Code quote:

 "pedersen_builtin": 8

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit cca3d02. Configure here.}

[cursor]

Regression diff and JSON have inconsistent values

Medium Severity

The regression diff states Deploy/constant/n_steps: 1183 but the versioned constants JSON for 0.14.4 has n_steps: 1181. The regression diff is auto-generated by comparing adjacent version JSONs, so these values must match. This inconsistency will cause test_vc_diffs_regression to fail.

Additional Locations (1)

• crates/blockifier/resources/blockifier_versioned_constants_0_14_4.json#L249-L250

 

^{Reviewed by Cursor Bugbot for commit cca3d02. Configure here.}