Skip to content

starknet_os: os resources test - deploy account tx calldata factor#14151

Open
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factorfrom
05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factor
Open

starknet_os: os resources test - deploy account tx calldata factor#14151
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factorfrom
05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factor

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Low Risk
Test and fee/resource constant tuning only; no runtime auth or execution-path logic changes.

Overview
Extends test_execute_txs_inner_resources so deploy account OS overhead is measured with two transactions (minimal vs one extra constructor calldata element), same pattern as invoke. The test now derives calldata_factor as the resource delta between them and sets the constant term to the minimal-tx overhead, replacing the previous TODO that only pinned the full overhead as constant.

blockifier_versioned_constants_0_14_4.json is updated accordingly: DeployAccount.calldata_factor drops from 37 steps and 2 Pedersen instances to 30 steps and 1 Pedersen (scaling factor 2 unchanged).

Reviewed by Cursor Bugbot for commit 8817938. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factor branch from b4fd833 to 77fc062 Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factor branch from 04d3d51 to 5af6585 Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factor branch from 77fc062 to b07e51e Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factor branch from 4a6103f to 5e52dfb Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factor branch from b07e51e to 4ff38f8 Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_calldata_factor branch from 4ff38f8 to 8817938 Compare May 29, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants