Skip to content

starknet_os: os resources test - add replace_class#14142

Open
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_support_virtual_builtins_add_sha256from
05-23-starknet_os_os_resources_test_-_add_replace_class
Open

starknet_os: os resources test - add replace_class#14142
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_support_virtual_builtins_add_sha256from
05-23-starknet_os_os_resources_test_-_add_replace_class

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Medium Risk
Changes syscall gas constants, blockifier OS resource tables, and the Starknet OS program hash, which affect fee accounting and OS compatibility; scope is narrow to ReplaceClass and test infrastructure.

Overview
This PR brings ReplaceClass syscall costs in line with measured OS resources and folds the syscall into the OS resources regression harness.

ReplaceClass gas in OS constants drops from 10670 to 10000, and blockifier 0.14.4 ReplaceClass VM resources go from 106 to 92 steps. program_hash.json updates the main OS hash to match the rebuilt program.

The Cairo1 os resources test contract now invokes replace_class_syscall during __execute__, and os_resources_test removes ReplaceClass from UNMEASURABLE_SYSCALLS so measured overhead is compared against versioned constants like other syscalls.

Reviewed by Cursor Bugbot for commit 6da1a91. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_replace_class branch 2 times, most recently from ed548b5 to 8be4f98 Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_support_virtual_builtins_add_sha256 branch from b11e870 to 61ef5ef Compare May 28, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants