starknet_os: os resources test - add emit event#14136
Conversation
PR SummaryLow Risk Overview The measurement contract invokes
Reviewed by Cursor Bugbot for commit 1d912ff. Bugbot is set up for automated code reviews on this repo. Configure here. |
08dbf97 to
f7fd3a3
Compare
844ec16 to
00a30cb
Compare
f7fd3a3 to
ce6eb29
Compare
00a30cb to
6b8d3d4
Compare
ce6eb29 to
f48908d
Compare
6b8d3d4 to
755576b
Compare
f48908d to
f30d4c1
Compare
755576b to
e06dbf0
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
@Yoni-Starkware reviewed 4 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).
crates/starknet_os_flow_tests/src/os_resources_test.rs line 220 at r1 (raw file):
// Extract syscall resources consumed, per (measurable) syscall. // There should be two events emitted: the first is the syscall we are measuring, and the second // is the last syscall in the tx, emitted from the fee transfer. Pop the second event.
You can run this tx with trivial fee bounds and make this test a bit cleaner
Code quote:
// There should be two events emitted: the first is the syscall we are measuring, and the second
// is the last syscall in the tx, emitted from the fee transfer. Pop the second event.e06dbf0 to
f058a8d
Compare
f30d4c1 to
ed74ad5
Compare
ed74ad5 to
7c9637b
Compare
f058a8d to
1d912ff
Compare

No description provided.