starknet_os: os resources test - l1 handler tx calldata factor

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• starknet_os: os resources test - add sha512 #14256
• starknet_os: generalize sha resource test to include sha512 #14255
• starknet_os: os resources test - l1 handler tx calldata factor #14152 👈 (View in Graphite)
• starknet_os: os resources test - deploy account tx calldata factor #14151
• starknet_os: os resources test - invoke tx calldata factor #14150
• starknet_os: os resources test - l1 handler tx constant factor #14149
• starknet_os: os resources test - deploy account tx constant factor #14148
• starknet_os: os resources test - declare tx #14147
• starknet_os: os resources test - invoke tx constant factor #14146
• starknet_os: os resources test - extract setup_test_builder #14145
• starknet_os: os resources test - add secp syscalls #14144
• starknet_os: os resources test - add send_message_to_l1 #14143 : 1 other dependent PR (#14153 )
• starknet_os: os resources test - add replace_class #14142
• starknet_os: os resources test - support virtual builtins, add sha256 #14141
• starknet_os: define sha256 batch resources constants #14140
• starknet_os: os resources test - add keccak #14139
• starknet_os: os resources test - add 3 more syscalls #14138
• starknet_os: os resources test - remove all fee transfer syscalls #14137
• starknet_os: os resources test - add emit event #14136
• starknet_os: os resources test - add meta tx #14135
• starknet_os: os resources test - measure linear factor, add deploy #14134
• starknet_os: os resources test - library call #14129
• starknet_os: initial test, measure call contract resources #14128
• blockifier_test_utils: add option to deploy from zero in test accounts #14258
• starknet_os_flow_tests: helper function to declare explicit classes #14257
• starknet_os: os resources test - create fixed deployable account #14173
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Low Risk
Regression test and versioned-constants snapshot updates for OS resource accounting only; no production execution-path changes in this diff.

Overview
Extends test_execute_txs_inner_resources so L1 handler OS scaffolding is measured with a base and extra-calldata pair (7 txs instead of 6), matching invoke and deploy-account.

The test now writes TransactionType::L1Handler versioned-constants entries as a constant base plus an unscaled calldata linear factor (l1_handler_extra − l1_handler_base), replacing the prior single overhead value and the TODO to compute that factor. The updated values are checked via the existing expect_file! snapshot against the latest versioned constants JSON.

^{Reviewed by Cursor Bugbot for commit 82597b0. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 82597b0. Configure here.}

[cursor]

L1 handler constant overestimates due to unscaled model

Medium Severity

The L1 handler constant is set to l1_handler_base, but for an Unscaled calldata factor (scaling_factor=1), the linear model constant + factor * n doesn't fit either measurement point. The base was measured at payload_size=1 and the extra at payload_size=2. Setting constant = l1_handler_base makes Model(1) = l1_handler_extra and Model(2) = 2*l1_handler_extra - l1_handler_base, overestimating by one full calldata factor at every payload size. The correct constant for an unscaled linear fit is l1_handler_base - (l1_handler_extra - l1_handler_base). This differs from the invoke/deploy_account cases where Scaled(2) makes the model exact at n=2.

Additional Locations (1)

• crates/starknet_os_flow_tests/src/os_resources_test.rs#L741-L743

 

^{Reviewed by Cursor Bugbot for commit 82597b0. Configure here.}