Skip to content

starknet_os: os resources test - add send_message_to_l1#14143

Open
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_add_replace_classfrom
05-23-starknet_os_os_resources_test_-_add_send_message_to_l1
Open

starknet_os: os resources test - add send_message_to_l1#14143
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_add_replace_classfrom
05-23-starknet_os_os_resources_test_-_add_send_message_to_l1

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@dorimedini-starkware dorimedini-starkware self-assigned this May 24, 2026
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review May 24, 2026 07:03
@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Medium Risk
Updates protocol-facing OS program hashes and syscall gas/step constants; mismatches would break proving or fee accounting, but changes are tied to regression measurement.

Overview
Adds send_message_to_l1 to the Cairo1 OS resources probe contract and the flow regression test, including an expected L2→L1 message assertion. SendMessageToL1 is removed from the unmeasurable-syscall list so its OS overhead is checked against versioned constants.

SendMessageToL1 OS cost is lowered (n_steps 144→124, SEND_MESSAGE_TO_L1_GAS_COST 14470→12470) in blockifier 0.14.4 JSON and Cairo OS constants. OS / virtual OS program hashes and the third allowed virtual OS program hash are updated to match the rebuilt program (program_hash.json, constants.cairo, VC diff regression).

Reviewed by Cursor Bugbot for commit a359fa6. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_replace_class branch from 9534bec to ed548b5 Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_send_message_to_l1 branch from 39edd2e to b4dc505 Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_replace_class branch from ed548b5 to 8be4f98 Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_send_message_to_l1 branch from b4dc505 to 6d69bf0 Compare May 28, 2026 16:18
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a359fa6. Configure here.

@@ -1,4 +1,4 @@
+ /os_constants/allowed_virtual_os_program_hashes/2: "0x66a46bb88553c4dafd12959575033660780d689c99659ab3620e2f524f71701"
+ /os_constants/allowed_virtual_os_program_hashes/2: "0x471dd673f38125ba94e98145e3579d700ad13bd0e177687b67bab6221da4fa0"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression diff file missing SendMessageToL1 n_steps change

Medium Severity

The SendMessageToL1 n_steps was changed from 144 to 124 in blockifier_versioned_constants_0_14_4.json, but the corresponding entry ~ /os_resources/execute_syscalls/SendMessageToL1/n_steps: 124 is missing from the 0.14.3_0.14.4.txt regression diff file. The test_vc_diffs_regression test uses expect_file! to compare the computed JSON diff against this file, so it will fail without this entry.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a359fa6. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants