Skip to content

starknet_os: os resources test - l1 handler tx constant factor#14149

Open
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factorfrom
05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor
Open

starknet_os: os resources test - l1 handler tx constant factor#14149
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factorfrom
05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Medium Risk
Updates fee-related OS resource constants for L1 handler transactions; impact is bounded by a full-OS regression test but incorrect values would mischarge users.

Overview
Extends the OS execute_txs_inner resource regression test to run a fourth transaction—an L1 handler—alongside invoke, declare, and deploy account, and writes the measured pure-OS scaffolding cost into the L1Handler constant under versioned constants for 0.14.4.

The committed constants change is only the constant term: n_steps 1315 → 1342 and pedersen_builtin 11 → 12; calldata-factor shape stays unscaled, with a TODO left to derive the linear factor later.

Reviewed by Cursor Bugbot for commit 92ed53b. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor branch from b5eae2f to 4a8df3d Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor branch from 43d9d8e to 3e2e6c5 Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor branch from 4a8df3d to dc5adbd Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor branch from 3e2e6c5 to cb37a07 Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor branch from dc5adbd to 67b8cfa Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor branch from cb37a07 to 22ef08b Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor branch from 22ef08b to 92ed53b Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor branch from 67b8cfa to 8ac7b12 Compare May 29, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants